Missing Text Domain

  • Resolved Alex Lion (阿力獅)

    (@alexclassroom)


    2 years, 9 months ago

    Hi,

    Version 2.0.0 is awesome, but I found a localizable string “Just another WordPress site” without text domain so this string cannot be displayed correctly.

    class-r34nono.phpm line 323

    'description' => sprintf(__('Removes the default WordPress tagline ("%1$s"). You will probably want to add your own tagline in its place eventually, but it is easy to forget and it often appears in unexpected places.', 'no-nonsense'), __('Just another WordPress site', 'no-nonsense')),

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author room34

    (@room34)

    Good catch… I’ll fix that tomorrow.

    Plugin Author room34

    (@room34)

    Actually… check that. This is a text string that is part of WordPress core, so the text domain should be optional (and would be 'default' anyway, not 'no-nonsense' in this case). It does not need to be translated in No Nonsense.

    That said… I see it’s in the no-nonsense.pot file. I auto-generated this file with Poedit, and I assumed it would not include this string because it’s not using the plugin’s text domain. I’ll remove it in the next update.

    Thread Starter Alex Lion (阿力獅)

    (@alexclassroom)

    I am zh_TW GTE, and I have translated WordPress from 4.9 till now.

    Please refer to this article.

    If there are strings in your plugin that are also used in WordPress core (e.g. ‘Settings’), you should still add your own text domain to them, otherwise they’ll become untranslated if the core string changes (which happens).

    From my experience, WordPress Core Team made some strings with a similar meaning minor changes in each core main version, this made the old rule you mentioned not apply to all situations.

    Additionally, why did I catch this? This is because before I do not add the missing text domain, the string “Just another WordPress site” does not display correctly.

    I took 3 screenshots for your reference.
    Screenshot 1: String “Just another WordPress site” is translated and its translation is same as zh_TW core.
    Screenshot 2: Code is not modified, and string “Just another WordPress site” cannot display correctly.
    Screenshot 3: Code is modified, and string “Just another WordPress site” displays correctly.

    Plugin Author room34

    (@room34)

    Thanks… that’s helpful to know. (I am certainly no expert with WP’s translation mechanisms.) I’ll make the change as you suggested.

    Plugin Author room34

    (@room34)

    Version 2.1.0 is now out with this change in place, along with a couple of fixes to other minor issues I noticed as I was testing.

    Let me know if this does not resolve the issue. Thanks!

    Thread Starter Alex Lion (阿力獅)

    (@alexclassroom)

    I created a whole new WordPress 5.9.3 zh_TW site and installed No Nonsense 2.0.0, this issue is the same. Then I updated No Nonsense to 2.1.0, confirming this issue is resolved.

    Thanks for fixing this so quickly, it is so helpful for all community translators like me.

    Plugin Author room34

    (@room34)

    Great, thanks for confirming that the issue is resolved!

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘Missing Text Domain’ is closed to new replies.