“mla_alt_ids_value” causes missing closing tag

  • Resolved nicegamer7

    (@nicegamer7)


    5 years ago

    I’ve noticed that when I use a shortcode like this:
    [mla_gallery attachment_category="the-cat" mla_alt_shortcode="test" mla_alt_ids_value="values"]

    the final output is missing the closing </div> tag. So it causes the page to render incorrectly. It’s easy to reproduce if you use a fake alternate shortcode (like test in the example above).

    My guess is that it has something to do with the if statement on Line 1789 in the class-mla-shortcode-support.php file. Please let me know if you can reproduce it.x

    Thanks.

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author David Lingren

    (@dglingren)

    Thanks for your report. Thanks as well for taking the time to sort through the code and post a link to the possible cause. I have run some tests on my system and discovered that when the mla_alt_ids_value is used MLA generates the style template, gallery open and row open HTML markup even though an alternate shortcode has been specified.

    I have corrected the MLA defect and uploaded a new MLA Development Version dated 20200314 that contains the fix. You can find step-by-step instructions for using the Development Version in this earlier topic:

    PHP Warning on media upload with Polylang

    It would be great if you can install the Development Version and let me know if it works for you. Thanks for alerting me to this MLA defect.

    Plugin Author David Lingren

    (@dglingren)

    I just patched a small defect in the Development Version uploaded 30 minutes ago. If you already installed it, please do so again. I regret the inconvenience.

    Thread Starter nicegamer7

    (@nicegamer7)

    Thanks for the speedy response. I can confirm it is fixed in the latest development version.

    Thread Starter nicegamer7

    (@nicegamer7)

    Additionaly the development version solved another problem I’ve encountered, which was that {+title+} was not being evaluated when placed in mla_alt_ids_value. I’m unsure if it’s related to this problem’s fix, but I am grateful nonetheless! Thanks.

    Plugin Author David Lingren

    (@dglingren)

    Thanks for your updates confirming the Development Version updates. The {+title+} evaluation defect was the fix I added 30 minutes after my first update. I am happy to see it helped.

    Plugin Author David Lingren

    (@dglingren)

    I have released MLA v2.82, which contains the fix for this defect. I am marking the topic resolved, but please update it if you have any problems or further questions regarding the fix. Thanks again for identifying this MLA defect.

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘“mla_alt_ids_value” causes missing closing tag’ is closed to new replies.