Modal not working for IE8

For me, the modals work great on IE9+, but not on IE8 or IE7.

Looking into IE 8 issues. We don’t officially support if for our own clients but as we want maximum compatibility in the plugin for your clients we will be addressing them as soon as the most efficient fix is determined.

we have fixed this on a client site so it works in ie8. its pretty simple, but there are a few changes needed:

1. rgba css doesn’t work in ie8 so we set some default background colours on the overlay div and .emodal class (black and white). for a full sultion you would need to detect browser in he script and add a hex rather than rgba in the js

2. you use the word “class” as variables in the defaults object. this is a reserved term, hence the expected identifier error in ie8 (other browsers just ignore it). we just changed that reference to “class_name” in the js file.

3. because of number 2 there is one part of the code (sorry forgot which part) that just passes all attributes to the object to be set. this had to be changed as otherwise it would a attribute of class_name=”classes” to the element.

with all that sorted it works in ie8, but obviously the css we have used is hard coded. for the plugin i would suggest browser detection and prevent the hex being converted to rgba for that browser.

Hey Lee,

Thanks for the tops we have been busy trying to keep up with support and it seems to be leveling off now. I will be making the following changes based on your info here.

1. Will do either browser detection and replace rgba with rgb and opacity if IE8 or lower.

2. I will have to look into this because the jQuery documentation actually recommends storing attributes in an object such as var attrs = { id: “theID”, class: ‘class1 class2″ } etc, so that you can simply do something like jQuery(this).attr(attrs); I didnt see mention of IE8 issues but will dig further and make changes if they are in fact neccessary.

3. Is due to #2 and the jQuery docs. Will look into it for sure.

On a side note i did just release an update so please be wary as these changes wont be there yet. Look for another release in the next week once i have checked on that jQuery IE8 issue.

Thanks for helping dig in and please consider our beta program we just kicked off as people like you willing to dig in and find issues are exactly what we need to move further faster.

Become Beta Tester

This thread is being marked as resolved due to inactivity until further notice. If this is not resolved, please let us know!