Moving custom credits to after footer

  • lucspe

    (@lucspe)


    7 years ago

    Hi there,

    First of all, thanks for the many plugins you released for StoreFront, a real time saver for providing a user interface in customizer for many options that otherwise would have to be set via code.

    For a project, I needed to hook the credits to storefront_after_footer.

    So, I slightly modified the plugin adding a select menu in the customizer to allow choice of whether the custom credit should be hooked to storefront_footer (default) or storefront_after_footer.

    What would be the best way to send you the modified code for you to consider including it in future releases?

    I tried checking if there was a GitHub repo or if you were on Making WordPress slack channel.

    Cheers,
    Luca

    p.s.: you might want to update plugin compatibility as it works on 4.8.x without a problem.

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author wooassist

    (@wooassist)

    @lucspe Thanks for your support! we will look into adding more features in our future releases. Thanks again.

    Thread Starter lucspe

    (@lucspe)

    Ok, but you have not answered my question ??

    How do I send you a pull request somehow?

    Thanks
    Luca

    Plugin Author wooassist

    (@wooassist)

    @lucspe Sorry but I have to decline your offer. You see we don’t aim to release advanced or overly-complicated plugins and it’s not yet in our plans if we will be releasing any premium versions in the future. That said, our focus will be to keep them simple but at the same time, make sure they are working perfectly, 100% of the time. Our continuous goal will be to keep our plugins 5-star rated.

    Feel free to help other users though if ever they need the feature you have.

    Thanks again.

    Thread Starter lucspe

    (@lucspe)

    I understand your point of view about keeping things simple.

    However the point is that – as it stands – the plugin assumes that the footer text is hardcoded into “storefront_footer” action hook.

    I believe the use case of moving the footer text after the footer (so hooked into storefront_after_footer) is not uncommon and whilst this can be achieved manually by a developer, I think the overall concept of the plugin is to make managing footer credits easy on the end user.

    So it is not an “advanced or overly complicated” modification (as it just adds a select box in customizer so the user can choose whether to place the text in the footer or after) and would make this otherwise very useful plugin a bit more flexible ??

    At any rate, case closed. Ultimately, this is your work so I respect your decision.

    I just would have preferred to avoid having to mantain a forked version of this for my sites, which is the reason why I approached you in the first place about this ??

    Cheers,
    Luca

    Plugin Author wooassist

    (@wooassist)

    @lucspe I also understand your case and I appreciate you contacting us regarding this. This is what a community means anyway. Thank you for your understanding.

    Wooassist

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Moving custom credits to after footer’ is closed to new replies.