Multiply, divide, plus, minus doesn’t work

  • Resolved adryyy

    (@adryyy)


    6 years, 6 months ago

    I found that these operations doesn’t work as they should.

    Fixed them by change this line

    if (((!is_string($pd_value)) AND ($pr_array['than_attribute'] != "shipping"))){

    into this

    if (is_numeric($pd_value)){

    in class-get-products.php

    However, this is a temporary solution, as i don’t use shipping attribute.

    I think there needs to be an additional OR condition, something like this

    if (((!is_string($pd_value)) AND ($pr_array['than_attribute'] != "shipping" OR $pr_array['attribute'] != "shipping" ))){

    but i can’t test this now.

    Also please consider to include alternative category path option in future versions

    https://www.ads-software.com/support/topic/category-path-problem-2/

    • This topic was modified 6 years, 6 months ago by adryyy.
Viewing 1 replies (of 1 total)

  • Hi adryyy,

    Thanks for having a critical look at the operator rules. You are right that the !is_string wasn’t fully working but unfortunately changing it to is_numeric is not the answer either as you have to take into consideration that annotations for numeric numbers sometimes contain a . and in other parts of the world a ,.

    That being said, we did make some extra changes to the code and pushed out a new version of the plugin that should solve the issue at hand. Just update the plugin and you should be fine.

    Have a wonderful weekend,
    Eva

Viewing 1 replies (of 1 total)
  • The topic ‘Multiply, divide, plus, minus doesn’t work’ is closed to new replies.