Multisite Compatibility

  • Resolved codejp3

    (@codejp3)


    2 years, 2 months ago

    As it stands, this plugin will work with multisite installs, but whatever ONE site (any site) sets in the option tabs applies to ALL sites.

    For a multisite install where the bbPress forum is SUPPOSED to look identical on every sub-site, that’s fine. For multisite installs where each site should be able to style the forum independently, this is a problem.

    I’ve tested it, and the “independent styling” is a problem whether bsp is network-activated, or optionally activated on a per-site basis.

    Do you have any plans to make this plugin multisite-friendly?

    It could be as simple as:

    1.) if network activated, provide a network admin option to choose – ONE style for ALL sites, or Independent styles for EACH site.

    2.) if network-activated and network admin option set to “ONE style” – display the bsp settings only in the network admin panel, generate single files from saved settings like it currently does, and enqueue those files for EVERY site.

    3.) if network-activated and network option set to “Independent styles” or plugin is NOT network-activated – then display bsp settings within each site admin panel like it currently does, and generate individual files per site ID, enqueuing only the files for each site individually.

    DB settings are currently being saved in a “multisite-friendly” way, per-site. The only thing really preventing this plugin from being fully multisite-friendly is the generated file names and how those files are enqueued. Maybe ONE style for ALL sites is fine, but maybe INDIVIDUAL styles for EACH site is what the network admin wants. Only thing preventing that from happening is file names/enqueueing, and the network admin option for selecting which way to apply bsp styles.

    Just wanted to plant the seed for this.

    If you’re OK adding yet another layer of complication to this plugin for the sake of full multisite compatibility, I’ll gladly contribute. If you have no desire to add full multisite compatibilty, then I’ll leave this one alone.

Viewing 15 replies - 1 through 15 (of 36 total)
  • Plugin Author Robin W

    (@robin-w)

    As per topic count, I like making my plugins as usable as possible and adding improvements, but have very limited time to look at these.

    I had never needed to look at multisite, and I’ve no idea how much work this would be for you, and indeed how much time it would take me to understand what you would have done – I need to be able to support versions, not just release them ??

    you say ‘Only thing preventing that from happening is file names/enqueueing, and the network admin option for selecting which way to apply bsp styles.’ – how easy is that to do, and hoiw easy for me to then understand?

    regards and thanks again for all you help ??

    Thread Starter codejp3

    (@codejp3)

    I gotcha.

    If I do pursue this, the easiest way would be for me to post the current version in GitHub, and then create a separate branch with my code revisions. That way you can see ONLY THE CHANGES between your code and my additions. Would help with the “understanding” part, and save you time trying to figure out what’s different.

    For now I’m going to leave this one be.

    If others chime in on this topic saying “YES, WE WANT MULTISITE SUPPORT”, then I’ll take the topic more seriously and pursue it.

    Plugin Author Robin W

    (@robin-w)

    that sounds like a plan ??

    Thread Starter codejp3

    (@codejp3)

    I’m going to move forward with this. I found myself stuck in a conundrum when it comes to multisite installs.

    Each site has to set BSP settings individually, but the generated files are setup specifically for ONE site. Make a change in one site, it re-generates files based on those settings, which don’t match the settings for each individual site.

    I’ve been trying to manage without re-writing the plugin for multisite compatibility, but there’s no way to resolve it except to generate files per-site based on each sites’ BSP settings individually.

    I created a new private GitHub repo for this. I’ll send you an invite link when I have something worthy of looking at.

    Plugin Author Robin W

    (@robin-w)

    thanks – happy to make the style pack plugin multisite if you can work out what needs doing ??

    Thread Starter codejp3

    (@codejp3)

    BIG Update coming your way later today…..

    Thread Starter codejp3

    (@codejp3)

    @robin-w – As promised, here’s proposed v5.2.6 update info.

    Private GitHub Repo:
    https://github.com/codejp3/bbp-style-pack

    Current 5.2.5 “main” branch:
    https://github.com/codejp3/bbp-style-pack/tree/main

    Proposed 5.2.6 branch:
    https://github.com/codejp3/bbp-style-pack/tree/proposed-v5.2.6

    Side-by-side code comparison “pull request”:
    https://github.com/codejp3/bbp-style-pack/pull/4/files

    Direct Download:
    https://github.com/codejp3/bbp-style-pack/archive/refs/heads/proposed-v5.2.6.zip

    Explanation & Demo Video:
    https://wp-multisite.local-dev.codejp3.com/temp-videos/bbp-style-pack-5-2-6.webm

    Multisite Dev Server Account created and password reset sent to you.

    GitHub Repo invitation link sent to you.

    Thread Starter codejp3

    (@codejp3)

    I will add that if this update is “too much” for a single update, I can split it into multiple updates.

    5.2.6 – Topic Count changes so those 2 plugin updates can be release at the same time.

    5.2.7 – Bug Fixes

    5.2.8 – Performance Tweaks

    5.2.9 – Multisite Compatibility

    5.3.0 – Translation Fixes

    More work on my part, but easier to digest if having all of these wrapped up into a single update is “too much”. It’s your plugin. Whatever works best for you.

    • This reply was modified 2 years, 1 month ago by codejp3.
    Plugin Author Robin W

    (@robin-w)

    very happy to do it as a single release – I’m 1/3 way through your video that is making excellent sense.

    I’m out a lot in the next 7 days, so planning on mastering the changes over the weekend, and releasing next Thursday when I am around after that, and hope that you can be available too should any issues arise – not expecting, but like to be available to rapidly fix anything that is not good.

    Thread Starter codejp3

    (@codejp3)

    I’ll be around, and offer any support I can. For both my additions/changes, or the plugin as a whole.

    Thread Starter codejp3

    (@codejp3)

    One more follow-up with the tinymce issue. I’ve narrowed it down and figured out the cause, and it actually DOES affect the current plugin 5.2.5 version and current WP 6.1.1 version as well.

    Making a separate support topic about it for further discussion:
    https://www.ads-software.com/support/topic/quotes-not-working-with-text-editor-only/

    Plugin Author Robin W

    (@robin-w)

    just a quick question – Do multisites need to do anything post 5.2.6 release, or will css files be automatically generated for each of their sites?

    Thread Starter codejp3

    (@codejp3)

    No. All of the magic for multisites is handled in /includes/generate_css.php (appends the site ID to each generated filename), and /bbp-style-pack.php activation hook function (regenerates deleted files when plugin is upgraded).

    As long as the code for those is intact, nothing extra or new is needed for multisites in future releases. It was coded so that if it’s not a multisite install, those multisite-specific things get ignored and it will generate/regenerate CSS/JS files like it always has (without any site ID appended to the filename).

    One thing I previously mentioned that I WANTED to do for multisites is to setup a network admin option to choose 1.) Network-Wide Settings For All Sites, or 2.) Individual Settings For Each Site. I ended up NOT doing that because there’s no clear way to code for it. The Style Pack settings can/will vary greatly largely based on the THEME a site is using. In a multisite install, each subsite can have their own theme, and quite often do. There’s no clear way to code for that, so I didn’t do it. What I chose to do personally as a workaround was utilize the already existing Import/Export Settings tabs within Style Pack. I have the styling setup on one subsite, and I just export those settings and then import them into all of the other subsites that I want to match.

    If I can ever clearly visualize a way to code for “Network-Wide Global Settings” then I may add that in the future. Until the coding path for that is clear, I’m not touching it and sticking to the Import/Export Settings workaround.

    Plugin Author Robin W

    (@robin-w)

    great – thanks

    I have now watched the video, and installed the new version on my site, and am just looking again at the code. But very happy with what you have done, the timestamp css is genius – such a great way to do it, never occurred to me to crack it that way. I plan to release as I said Thursday/Friday next week – thanks again for the significant improvements you have made

    Thread Starter codejp3

    (@codejp3)

    Sounds good!

    I’m still playing around and trying to test as much as possible to find any last minute hidden issues/bugs, but so far everything is working great.

    If I find any issues, I’ll patch them, update the GitHub repo and notify you as well.

Viewing 15 replies - 1 through 15 (of 36 total)
  • The topic ‘Multisite Compatibility’ is closed to new replies.