• Resolved codejp3

    (@codejp3)


    As it stands, this plugin will work with multisite installs, but whatever ONE site (any site) sets in the option tabs applies to ALL sites.

    For a multisite install where the bbPress forum is SUPPOSED to look identical on every sub-site, that’s fine. For multisite installs where each site should be able to style the forum independently, this is a problem.

    I’ve tested it, and the “independent styling” is a problem whether bsp is network-activated, or optionally activated on a per-site basis.

    Do you have any plans to make this plugin multisite-friendly?

    It could be as simple as:

    1.) if network activated, provide a network admin option to choose – ONE style for ALL sites, or Independent styles for EACH site.

    2.) if network-activated and network admin option set to “ONE style” – display the bsp settings only in the network admin panel, generate single files from saved settings like it currently does, and enqueue those files for EVERY site.

    3.) if network-activated and network option set to “Independent styles” or plugin is NOT network-activated – then display bsp settings within each site admin panel like it currently does, and generate individual files per site ID, enqueuing only the files for each site individually.

    DB settings are currently being saved in a “multisite-friendly” way, per-site. The only thing really preventing this plugin from being fully multisite-friendly is the generated file names and how those files are enqueued. Maybe ONE style for ALL sites is fine, but maybe INDIVIDUAL styles for EACH site is what the network admin wants. Only thing preventing that from happening is file names/enqueueing, and the network admin option for selecting which way to apply bsp styles.

    Just wanted to plant the seed for this.

    If you’re OK adding yet another layer of complication to this plugin for the sake of full multisite compatibility, I’ll gladly contribute. If you have no desire to add full multisite compatibilty, then I’ll leave this one alone.

Viewing 6 replies - 31 through 36 (of 36 total)
  • Thread Starter codejp3

    (@codejp3)

    Dare I say it…. we might FINALLY be sorted and have a good solid “stable” starting point for all future additions ?? ….3 updates later ??

    I do have some other projects to wrap up so I won’t be putting as much time into BSP, but as I use the plugin and notice things, I’ll fix/enhance them and send the code your way.

    Plugin Author Robin W

    (@robin-w)

    thanks – I’m away for 2 weeks from next Thursday – little trip to Egypt !!

    Thread Starter codejp3

    (@codejp3)

    Awesome! Enjoy it!

    In the meantime, if you’re OK with it, list me as an official code commiter and I can handle minor updates to fix any reported issues from users until you get back.

    What I may do during that 2 weeks is another update to whip the translations and gettext strings into shape. Took care of a good chunk already, but there’s still some strings not in gettext wrappers, and several that are not 100% gettext compliant or machine-translation-friendly. I’d wait until you got back before publishing it so you can view it first and have final say on what gets published (assuming you make me a code commiter).

    Thread Starter codejp3

    (@codejp3)

    @robin-w – got another multisite compatibility update coming your way either later today or tomorrow.

    Plugins are handled differently with multisite and I noticed the plugin_info tab wasn’t displaying multisite plugins properly. I swear I was only going to address that ONE SINGLE THING …..but OF COURSE it lead to complete revamp of the entire plugin_info tab and how tabs are handled in-general. Quite a bit has changed so I’ll post it on GitHub so you can do the side-by-side comparison.

    Until then, here’s a teaser pic ??

    Plugin Author Robin W

    (@robin-w)

    @codejp3 – I’m keen to do incremental change, and not do changes when you are working on things – You are working on changing how all the settings tabs work – is that nearing completion?

    Thread Starter codejp3

    (@codejp3)

    @robin-w

    I wish I could release this one in smaller chunks, but it’s a full re-write of how settings are handled so it really needs to be done all at once. Don’t freak out by me saying that either. The settings are largely untouched, but how they’re defined and rendered is completely new. It’ll make the settings page completely versatile where any setting field can be rendered on any tab, and “like” settings can be grouped together regardless of the option group they belong to. It also means that formatting and sanitizing of all settings is handled prior to saving to the DB. You were previously locked into only being able to render fields per-option group on a per-tab basis. This removes that limitation altogether. Changes to tabs/settings is now as simple as changing array values without ever touching any code. Adding a new tab or any new settings is simply defining an array for it. No need to touch any code unless it’s something non-standard. It removes all limitations that previously existed, and standardizes everything that’s currently there. Since less code has to be touched for future updates, it makes overlooked issues far less likely in the future.

    I hope it’s near completion, but realistically it may be another two weeks. As usual, I’ll do a video or two covering all the important parts.

    Your concerns are being integrated into the new revision.

    It won’t get pushed out as an official stable update until we test it with some volunteer BETA testers first and iron out any bugs. Version 5.2.6 was a big learning lesson on that!

    If you want/need to release any other updates prior to this one being ready, go for it. I’ll adapt them to the revision I’m doing.

Viewing 6 replies - 31 through 36 (of 36 total)
  • The topic ‘Multisite Compatibility’ is closed to new replies.