Multisite imcompatible (and less)

  • Resolved screamingdev

    (@screamingdev)


    5 years, 1 month ago

    Dear folks,

    this plugin is multisite incompatible.

    One example would be a query like

    “UPDATE wp_posts SET post_parent = %d, menu_order = %d WHERE ID = %d”

    ( see \F4\TREE\Tree\Hooks::ajax_move_tree_post )

    Actually this is very dangerous in a multi-site because you edit things on a complete different table.
    This is also dangerous for single-sites because when the db-prefix has changed, then you update a very different table that has nothing to do with the current WordPress that the user works with.

    In addition:

    In \F4\TREE\Core\Helpers::get_settings you set [ 0 => post, 1 => page ] as default value
    but in the actual settings section you store [ post => 1, page => 1 ] .
    Even worse, when the array contains [ foo ] then all post-types get the tree view.

    Please let me know if you need someone that helps with the code review.
    I stop after 5 minutes and let you know what I found (so far).

Viewing 3 replies - 1 through 3 (of 3 total)
  • Thread Starter screamingdev

    (@screamingdev)

    srv/wp-content/plugins/f4-tree/Tree/Helpers.php:224 …
    self::get_children(‘page’, $post_item->ID, $current_post_id);

    Page. So, whatever I choose or am working with, this plugin only works for pages.

    Plugin Author FAKTOR VIER

    (@faktorvier)

    Hello @screamingdev

    Sorry for the late answer and thank you for your feedback!
    We’re looking into this issue and get back to you as soon as possible.

    Plugin Author FAKTOR VIER

    (@faktorvier)

    Hi @screamingdev

    Thanks again for your feedback.

    We added a few fixes to our new release, including the ones you mentioned.

    This plugin does still not officially support multisite pages, but we’ll release an multisite update in the near future.

    You sure can review our code even further if you like to, that would really help us fix problems we didnt encounter on our own pages that uses this plugin.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Multisite imcompatible (and less)’ is closed to new replies.