MySQL warnings from helper-function.php code

Hello @crazyserb,

Thank you very much for reaching out to us.

I am sorry to hear about the warnings you have encountered after installing the plugin.

After carefully reviewing your message and screenshot, the issue you are facing seems unsusal.

With all due respect, it’s unlikely that ShopLentor will cause such an issue. There may be a conflict with a third-party plugin on your website.

However, we’ll definitely investigate the plugin further and address any such issues we come across during our investigation.

Thank you once again for bringing this to our attention.

Wishing you a wonderful day ahead!

Best regards,
Tarek Aziz

Well, whether that’s a conflict with another plugin (maybe Elementor / Elementor Pro or Rank Math / Rank Math Pro?) or not, it’s somehow caused by this plugin, because with it turned OFF, we don’t have any of these issues… but yeah, if you can take a look at it, and I can send you a list of plugins we’re using on our end to test with, if you want, that’d be great.

Thank you so much, @crazyserb, for the prompt response.

Yes, absolutely! We are more than happy to look into our plugin and address any issues that are found.

Therefore, it would be greatly appreciated if you could kindly send a list of the plugins currently active on your website.

Could you please create a ticket in our dedicated support center?

https://woolentor.com/contact/

This will help us determine the issue quicker and provide an effective solution.

Kind regards,
Tarek Aziz

Hello @crazyserb,

I hope you are doing well.

I just wanted to let you know that we have thoroughly investigated the plugin and resolved the issue in the latest update.

Could you please update the plugin to its most recent version and check if it resolves the issue?

Please let me know how it goes. Your feedback would be greatly appreciated.

Wishing you all the best!

• This reply was modified 1 month ago by Tarek Aziz.

Hmm, nope. Those errors are still coming up, hundreds per second.

In the case of the first one reported I only see this variation of it now:

2024-10-24 4:00:38 user @ localhost [] WARNING 1292: Truncated incorrect DECIMAL value: '' : SELECT MIN( CAST( meta_value AS DECIMAL(10, 2) ) ) FROM wp_postmeta WHERE meta_key = '_price'

where the value is empty. I guess you fixed the issue for non-empty values.

Taking a look at your code, I can assume that the full fix for that query would look something like this

SELECT MAX( CAST( meta_value AS DECIMAL(10, 2) ) ) FROM {$wpdb->postmeta} WHERE meta_key = %s AND meta_value != '' ...

However, the 2nd error reported, with the long query, that one is still being logged over and over. And I can’t figure out where that’s coming from either from which specific function/code…

• This reply was modified 1 month ago by CrazySerb.

Hello @crazyserb,

Thanks for sharing your feedback. We are not experiencing such issues on our end.

Anyway, there is nothing to worry about. Would you kindly make some changes to the queries whose screenshot you shared earlier?

Please make sure that you use meta_value REGEXP ‘^[0-9]+(\.[0-9]+)?$’ for both $value_min and $value_max

Hopefully, it will fix the issue.

Here is an example for your convenience:

$value_min = $wpdb->get_var( $wpdb->prepare( "
    SELECT MIN( CAST( meta_value AS DECIMAL(10, 2) ) ) 
    FROM {$wpdb->postmeta} 
    WHERE meta_key = %s 
    AND meta_value REGEXP '^[0-9]+(\.[0-9]+)?$'", 
    '_price' 
));

Please keep me updated on the status of this issue. I eagerly look forward to hearing from you.

Best regards,
Tarek Aziz

Yeah, that fixes the 1st one, definitely.

Now, as far as that 2nd one, it has something to do with Elementor Pro plugin, as if I turn off either one (Elementor or Shoplentor) of the plugins the problem goes away. Obviously, kinda need both, so… any idea on how to go about fixing that query?

Did you push this change on your end to your core code as well?

I think I got an update pushed on my end and it didn’t have this code in place, so I had to re-apply this fix all over again.

Hello @crazyserb,

We are extremely sorry for any inconvenience it may have caused.

It seems the change was unintentionally included in the core. Please rest assured that we’ll address this in the next update.

Thanks a lot for your understanding and patience!

Here’s another “PHP Warning” that we’re seeing constantly clog up our error_log:

PHP Warning: Undefined array key “max_price” in /home/public_html/wp-content/plugins/woolentor-addons/classes/class.product_query.php on line 260
PHP Warning: Undefined array key “min_price” in /home/public_html/wp-content/plugins/woolentor-addons/classes/class.product_query.php on line 260

Might be another check for valid values requred in that file instead of assuming all these values will always end up returning as expected per your default scenario.

Or rather, that get_meta_query() function might need this line changed:

    if( isset( $_GET['min_price'] ) || isset( $_GET['max_price'] ) ){

to use AND instead of OR condition.

Hi there,

Thank you very much for bringing these warnings to our attention. Also, we greatly appreciate you for sharing your thoughtful suggestions with us. Don’t worry; we’ll thoroughly investigate our plugin and do our best to resolve the issue in the next update.

In the meantime, your patience and cooperation are highly expected as we work on this ??

Wishing you a wonderful day ahead!