Naming convention clash

  • Resolved Gal Baras

    (@galbaras)


    1 year, 9 months ago

    Looks like the taxonomy “category” is associated with the “series_grouping” post type, as well as with “post”, and this creates a confusion in Rank Math SEO settings, and possibly other places.

    When a plugin defines a taxonomy, it’s good to use a unique prefix for its name. In this case, “series_category” seems to make sense, to be distinct from the generic WordPress “category”.

    See orgseries_grouping_posttype() in addons/groupings/legacy-includes.php (line 195).

    Personally, I find “series_grouping” a confusing name for a post type. I expected it to be a taxonomy by its name. Also, there are 3 posts with this post type in my database, none of which have any references that I can find, and all of which result in 404 pages.

    Why is this post type needed?

    • This topic was modified 1 year, 9 months ago by Gal Baras.

    The page I need help with: [log in to see the link]

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Support Riza Maulana Ardiyanto

    (@rizaardiyanto)

    Hi @galbaras

    Series Category Taxonomy slug is series_grouping and in real sense, it should have been series_category but that happen because the actually Taxonomy name is Series Group and we changed the label few months ago in https://github.com/publishpress/publishpress-series/issues/613

    We didn’t change slug which did make sense and it’s the best transition without affecting legacy usage

    But having the slug as series_grouping shouldn’t have a negative effect since that’s what it used to be and we only change the label from Series Grouping.

    For example, if we change the label back to Series Grouping or assume we never change the label, what effect does this have?

    Or can you please explain what the issue with RankMath alongside with any screenshots related to the issue?

    Thread Starter Gal Baras

    (@galbaras)

    Besides the confusion of labels, the category taxonomy is associated with the series_grouping post type (it’s NOT a taxonomy – see here), and that shouldn’t be true.

    Also, as I said, this post type doesn’t seem to be used, so it should be removed from the code, possibly after some migration of old data.

    Plugin Support Riza Maulana Ardiyanto

    (@rizaardiyanto)

    Thanks, we have converted this to GitHub task: https://github.com/publishpress/publishpress-series/issues/742

    You can monitor the update on that task.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Naming convention clash’ is closed to new replies.