Needs some fixes with Gravity Forms 2.5

  • Resolved Jon Fuller

    (@garconis)


    3 years, 6 months ago

    Please run another test with Gravity Forms 2.5.
    https://gformtest-jf.freshy.site/contact/

    You can see a few issues that need to be adjusted. First is the field errors. You can see for some reason the top padding is being set to 0 on each field error: https://i.imgur.com/MUN2Yyp.png

    It seems to be something that Gravity Forms is doing themselves, but I’m not sure why.

    —

    There also seems to be a minor positioning issue with the main error message, since the text isn’t vertically centered with the X icon. Seems to be a result of Divi’s bottom padding on the H2.

    —

    Lastly, I noticed that you didn’t update your code to take into consideration the new way that Gravity Forms deals with columns. This is now causing the right edge to be pulled out 16px too far: https://i.imgur.com/EP6vLQT.gif

    This is due to your rule of:

    @media (min-width: 641px) {
    body .gform_wrapper .gform_body {
        width: calc(100% + 16px);
    }
}

    —

    You also no longer need some of the rule with the li elements, since they no longer use list item elements to wrap their fields.

    —

    I also think your width of 8em could be removed from the date picker class, since it causes the yyyy placeholder to get cut off. Similarly, I’m not sure your 6px of right padding is needed on some of the date fields. Nor is the .gfield_time_hour i rule necessary anymore, as far as I can tell.

    —

    And your rule of 

    body .gform_wrapper li.hidden_label .ginput_container>* {
	margin-top: 12px
}

    Needs to be updated since GF 2.5 no longer uses the li

    —

    Please go through each rule and see what is still needed. Thanks!

    • This topic was modified 3 years, 6 months ago by Jon Fuller.
    • This topic was modified 3 years, 6 months ago by Jon Fuller.
    • This topic was modified 3 years, 6 months ago by Jon Fuller.

    The page I need help with: [log in to see the link]

Viewing 10 replies - 1 through 10 (of 10 total)
  • Plugin Author Surbma

    (@surbma)

    Hi @garconis ,

    thank you for the feedback and the detailed informations! I will check again the form and fix everything to be 100% compatible with the new Gravity Forms.

    I will let you know, when new version is available.

    Thread Starter Jon Fuller

    (@garconis)

    Any update on this?

    Plugin Author Surbma

    (@surbma)

    Hi @garconis,

    sorry, still not ready with the new version. I’ve tested it with legacy mode and didn’t noticed this option, sorry!

    New, fixed version is coming soon! If you want to keep the original design, you need to use your forms in legacy mode. The new version of this plugin will only support the new Gravity Forms structure.

    I will keep you posting with the development.

    Thread Starter Jon Fuller

    (@garconis)

    No worries. I look forward to it supporting the new Gravity Forms code, since I’m interested in updating them, so I don’t need to rely on Legacy anymore.

    Thread Starter Jon Fuller

    (@garconis)

    Any update here? Would love to continue utilizing your plugin to make Gravity Forms look great with Divi, but currently, it’s still a bit wonky. ??

    Plugin Author Surbma

    (@surbma)

    Hi @garconis,

    sorry for the delay! The new version has just been released with full support for new markup. It also supports the legacy markup, so you don’t have to worry about any of your forms!

    Thank you for your patience and your detailed request! Please update the plugin and let me know, if it works or still has any parts to fix.

    Thread Starter Jon Fuller

    (@garconis)

    Looks pretty good, but input errors seem to need additional top padding that the Gravity Forms theme.css is removing: https://i.imgur.com/oeu8S8V.png

    They are removing padding top when the form input uses Descriptions Above the Inputs via:

    .gform_wrapper.gravity-theme .field_description_above .gfield_description

    But they unfortunately are therefore also removing the top padding from the actual validation message too, since that also uses the gfield_description class.

    So could probably add CSS like:

    .gform_wrapper.gravity-theme .field_description_above .gfield_description.gfield_validation_message {
    padding: 12px 16px;
}
    Plugin Author Surbma

    (@surbma)

    Strange…it is good on my local install. I can not replicate this issue. Can you please share a link, where I can check it?

    Thread Starter Jon Fuller

    (@garconis)

    Did you test with these settings: https://i.imgur.com/5Ff7Zvy.png

    Plugin Author Surbma

    (@surbma)

    Ok, got it. ?? Fixed. New version 4.1 has been released.

    Thank you again!

Viewing 10 replies - 1 through 10 (of 10 total)
  • The topic ‘Needs some fixes with Gravity Forms 2.5’ is closed to new replies.