Nested check enhance to be Cycle check

  • Resolved mrn3

    (@mrn3)


    4 years, 7 months ago

    I have seen the discussion on

    https://www.ads-software.com/support/topic/nested-inserts-possible/

    and I have disabled that check accordingly, and it is working well.

    However, I am still worried that someone will create a cycle.

    Couldn’t the check be enhanced so that instead of being a insert_pages_apply_nesting_check, it would be a insert_pages_apply_cycle_check ? I realize this is harder, but it would be nice to not have to have the risk, and if it detects a cycle, it just stops rendering, or even has an error that a cycle has been detected.

Viewing 6 replies - 1 through 6 (of 6 total)

  • Hi mrn3!

    I have started a topic, as I would need nesting.
    https://www.ads-software.com/support/topic/nesting-pages-3/

    If I understand well, nesting works for you.
    Could you tell me, how did you do it?
    (It used to work on my site,too, however now it stopped…)

    Thanks a lot!

    Greetings

    Tamas

    Plugin Author Paul Ryan

    (@figureone)

    Thanks for the suggestion, I think it’s a good idea. We are working on replacing the nesting check with better loop detection, so it should allow nested pages by default. Stay tuned…

    Plugin Author Paul Ryan

    (@figureone)

    Better loop detection added here:
    https://github.com/uhm-coe/insert-pages/commit/d445bda3d9985ce670138f385744a6469f81f0f6

    The plugin now tracks which pages it has inserted, and if it encounters one that’s already been inserted, it stops rendering further

    This will be included in the next release. Thanks for the suggestion!

    Thread Starter mrn3

    (@mrn3)

    okay great thanks! so when will that be release? when it is, I will upgrade, but then should I just disable the should_apply_the_content_filter setting I enabled already?

    Plugin Author Paul Ryan

    (@figureone)

    It was released yesterday (v3.5.3.2).

    The insert_pages_apply_nesting_check filter was removed, because nesting should work now by default (with a different system to detect loops). If you still are hooking into that filter it’s fine, it just won’t do anything.

    Thread Starter mrn3

    (@mrn3)

    ok great thanks!

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Nested check enhance to be Cycle check’ is closed to new replies.