Nesting pages

  • Resolved Haim

    (@koostamas)


    4 years, 7 months ago

    Hello!

    I used to have an issue with nesting pages:
    https://www.ads-software.com/support/topic/nested-inserts-possible/
    At that time it was well resolved with this code:

    // ****START******** for Insert Pages plugin
function spacious_init() {
// Disable nesting check to allow inserted pages within inserted pages.
add_filter( ‘insert_pages_apply_nesting_check’, ‘__return_false’ );
}
add_action( ‘init’, ‘spacious_init’ );
// ****END******** for Insert Pages plugin

    I have just updated my template, Spacious to 1.7.1

    I have added again the code above… And it does not work now.
    When nesting a page, it’s content is not displayed,

    How can I make it work, so pages can be nested?

    WP 5.3.2,
    SPACIOUS 1.7.1
    PHP 7.2.29

    Thanks!

    Tamas

    The page I need help with: [log in to see the link]

Viewing 10 replies - 1 through 10 (of 10 total)
  • Thread Starter Haim

    (@koostamas)

    I have updated to wp 5.4
    The issue persist…

    Plugin Author Paul Ryan

    (@figureone)

    I think WordPress core may have changed some filter order. We are working on replacing the nesting check with better loop detection, so it should allow nested pages by default. Stay tuned…

    Plugin Author Paul Ryan

    (@figureone)

    Checked again, the insert_pages_apply_nesting_check works fine on vanilla WordPress, so there may be another plugin causing this behavior. What plugins do you have enabled?

    Thread Starter Haim

    (@koostamas)

    Greetings, Paul!

    My plugins:

    Classic Editor
    Version 1.5 | By WordPress Contributors

    Contact Form 7
    Version 5.1.7 | By Takayuki Miyoshi

    Duplicate Page
    Version 4.2 | By mndpsingh287

    Duplicator
    Version 1.3.30 | By Snap Creek

    Easy Media Download
    Version 1.1.4 | By naa986

    Insert Pages
    Version 3.5.2 | By Paul Ryan – *** obviously ??

    Polylang
    Version 2.7.1 | By WP SYNTEX

    Shortcodes by Angie Makes
    Version 3.46 | By Chris Baldelomar

    TablePress
    Version 1.11 | By Tobias B?thge

    WP Dashboard Notes
    Version 1.0.9 | By Jeroen Sormani

    WP Mail SMTP
    Version 1.9.0 | By WPForms

    WP Super Cache
    Version 1.7.1 | By Automattic

    Yoast SEO
    Version 13.5 | By Team Yoast

    Thanks a lot!

    Tamas

    Plugin Author Paul Ryan

    (@figureone)

    Version 3.5.3 was just released with loop detection enabled by default. Please test and let us know if it resolves your issue!

    Thread Starter Haim

    (@koostamas)

    Thanks, Paul!
    Very quick help! really appreciate it.

    Interesting! In most of the cases it WORKS now.
    However, there are some cases when it does not display the inserted page.

    Look at this page (in English).
    There is a series of songs. Everywhere the “About the instrument>>>” should show the description page of the given instrument.
    In the second and the fourth song it just does not work. In all other cases it works fine.
    Strange enough!
    However, the structure is the same everywhere…

    By the way, in the Hungarian version the situation is the same, the 2nd and the 4th are exceptions, they do not work, however, all the others do work fine.

    For me all the songs are written in the very same way, should react in the very same way, as well…
    What do you think?

    Greetings,

    Thanks a lot!

    Tamas

    Plugin Author Paul Ryan

    (@figureone)

    I think I might know why…the new loop detection we rolled out just checks to see if a page has been inserted already, and stops if it has. It sounds like you might have a page that inserts the same page multiple times, but not in a looping scenario.

    A looping scenario would be: A inserts B, B inserts C, C inserts A.

    You probably have something like: A inserts B, then inserts B again, then inserts B again.

    We will try to make the loop detection stack work for this scenario. Stay tuned…

    Plugin Author Paul Ryan

    (@figureone)

    Ok, version 3.5.3.2 is now released, which should *hopefully* address the problem. Please test!

    Thread Starter Haim

    (@koostamas)

    Hi Paul!

    YES, exactly this is the case, I insert a given page several times within the same page!
    And your new release seems the work PERFECTLY!

    thanks a lot!
    Very quick and friendly help.
    Thanks and congratulations!

    My i buy you a coffee?
    (How may I send you money?)

    Friendly greetings from Budapest, Hungary

    Tamás

    Plugin Author Paul Ryan

    (@figureone)

    Excellent! No need for donations, my university supports my work on this open source project (College of Education at the University of Hawai‘i at Mānoa).

    Pay it forward next chance you get, and please stay safe and healthy!!

    Cheers from Honolulu

Viewing 10 replies - 1 through 10 (of 10 total)
  • The topic ‘Nesting pages’ is closed to new replies.