New plublishpress__loaded action

Hi @galbaras

Thanks for using PublishPress Series.

There are multiple places where we added it. You can view the changes here: https://github.com/publishpress/publishpress-series/commit/86420691706f09fb8810f8b7e57ab7159db2ca2b

Hope that helps.

I can’t find a single occurrence of plublishpress__loaded on the page ??

@galbaras Can you let me know what you are trying to achieve here?

Just checking the listed change, because it seemed strange, and because changing action hooks can cause issues.

Hello @galbaras

We didn’t change hooks that could have effect on third part or plugins usage.

All changes are internal usage and in this case, while trying to refactor the plugin to fix some issues related to library conflict and migrating the plugin vendor to an internal vendor, we made sure plugins_loaded is only used once in the plugin and that explain while there’s replacing ‘plugins_loaded’ in the changelog.

In case of series, the name slightly changed to publishpress_series_after_init to reflect the need for the other action previously hooked to plugins_loaded to be changed to publishpress_series_after_init and this new action is loaded inside the only plugins_loaded in the plugin.

In practically, they still run inside plugin_loaded just that they do when we want them to which is after the plugin init.

Nevertheless, they changes are internal plugin usage changes and contrary to what you said, they have no serious or any implication with any other thing neither did we changed original hook usage for others.

Regards.

Hello @galbaras

We didn’t change hooks that could have effect on third party or plugins usage.

All changes are internal usage and in this case, while trying to refactor the plugin to fix some issues related to library conflict and migrating the plugin vendor to an internal vendor, we made sure plugins_loaded is only used once in the plugin and that explain while there’s replacing ‘plugins_loaded’ in the changelog.

In case of series, the name slightly changed to publishpress_series_after_init to reflect the need for the other action previously hooked to plugins_loaded to be changed to publishpress_series_after_init and this new action is loaded inside the only plugins_loaded in the plugin.

In practically, they still run inside plugin_loaded just that they do when we want them to which is after the plugin init.

Nevertheless, the changes are internal plugin usage changes and contrary to what you said, they have no serious or any implication with any other thing neither did we changed original hook usage (in WordPress context) for others.

Regards.

Got it. I could verify the change on Github, but the plugin still has plugins_loaded in several files under lib/vendor/publishpress and the changelog still has a typo and a formatting issue (<name> is taken as a tag).

Thanks @galbaras

The lib/vendor part you mentioned is a vendor library.

If you need to understand how our code work, kindly take your type to explore the repository.

Support is meant to attend to issues found in the plugin.

Regards.

This makes sense (now).

The changelog still has a typo and a formatting issue due to the use of angle brackets. Maybe you can take a look at it?

@galbaras Which typo and formatting issue on changelog you are referring to?

Is it this one: https://www.ads-software.com/plugins/organize-series/#developers ?

Yes. "plublishpress__loaded" should be publishpress_<name>_loaded (no “l” after the first “p” and the angle brackets should be HTML escaped. See your readme.txt file on Github.

@galbaras Ah, we did missed this. Thank you for your report. I’ve notified our developer about this.