New update error

Hey Paeder – Sorry to hear about the issue. We’ll get you fixed up. Can you let me know, is this error on the frontend or backend?

I thought that the error was only occurring on the front end.
But I’ve just gone in and checked and although it loads the map and seems to function the back end also has several errors.
Mostly failed to load resource 404 errors for the markers

/google-maps-builder/assets/img/default-icons/orange_markerG.png 404 (Not Found)

and

You have included the Google Maps API multiple times on this page. This may cause unexpected errors.

Hey Paeder – can you try deleting the plugin and reinstalling it again? I think you may have an issue on install. If that doesn’t work, please email us at support (at) wordimpress.com and we’ll take a closer look.

Hi, same issue here. I’ve tried to delete and reinstall your plugin but I get the same errors:
– front-end: no maps and “Reference Error: google is not defined” in
https://…/wp-content/plugins/google-maps-builder/assets/js/frontend/google-maps-builder.min.js
and
https://…/wp-content/plugins/google-maps-builder/includes/libraries/map-icons/js/map-icons.js

– back-end:”NetworkError: 404 Not Found – https://…/wp-content/plugins/google-maps-builder/assets/img/default-icons/orange_markerI.png”

When I helped Paeder it seemed like permissions issue going on. The file in question was there, it was just not accessible by the network. I’d love to get hands on with this problem. @gparonitti any chance I can view your site?

Yes the site is eyevis.it the front-end page is:
https://www.eyevis.it/contatti/

thx.

The problem with the backend is an incorrect naming of the marker-icons orange files: the plugin call for orange_markerX.png but the files are orange_MarkerX.png. Solved by changing /google-maps-builder/includes/admin/views/markers.php accordingly.

Now I’m getting to the front end problem…

That’s probably why I’m having a hard time reproducing… my server doesn’t care about the capitalization but yours does…

I’ll need to release a fix for this.

On the frontend of your site it looks like the Google Maps scripts are never being output. Does your theme’s footer have wp_footer() within it?

Yes, it has.

I worked around the problem modifying /google-maps-builder/includes/class-gmb-scripts.php: I commented the load_maps_api variable checking on line 138. It is not a good solution, but just for now ??

It seems that the function check_for_multiple_google_maps_api_calls doesn’t work properly since it incorrectly sets load_maps_api to false (at least on my site).

I’d like to figure out WHY it’s doing this…

There must be something triggering it to false unless we have a bug in our code. Is your theme or another plugin outputting Google Maps API scripts that you no of?

No there is no other plugin outputting Google Maps API.
I did some other debugging. It seems to me (but I usually don’t develop in php) that there is an unusual way to enqueue the google maps script.

If I correctly understand why you use wp_print_scripts in combination with wp_footer action is to write the google maps scripts on the footer. But why not use $in_footer parameter of wp_register_script() function?
And
In check_for_multiple_google_maps_api_calls function, you check the google maps api call on the $registered_script and not on the enquequed script by parsing the global $wp_scripts->registered array. Since the scripts are registered the condition in the foreach is verified and thus the protected load_maps_api is set to false and the google maps script is not printed. Why don’t use wp_script_is function?
I’ll try to refactor this part of the code.
What seems quite puzzling is that this is happening only to me. Did peader solve the front-end issue?

I’m afraid this issue won’t be isolated to just you. I haven’t been able to fully debug that functionality to be honest. We had a contractor build it into the plugin and I did some initial testing with various plugins I knew threw in Google Maps API into the frontend like Uber Menu and other Gmaps plugins.

Did you know this plugin is on Github? I’d LOVE a pull request from you if you polish up that conditional google maps loading functionality that we have. Here’s the link to the repo: github.com/WordImpress/google-maps-builder

If you do decide to contribute I’ll also throw in a free upgrade to the Pro version for your time.

Thanks!

Also, I’m not sure what happened to Paeder…

I pulled a request to your git repo, I didn’t touch the function since, after a second thought, it seems to me that the logic is correct (imho the problem is linked to the fact that the checking is implemented against the registered array and not on the actual enqueued scripts), I just changed the way the gmaps api script is loaded. Anyway I writed all in the comment to the pull request.