Next update!
-
Hey ivmartel! How are you?
Thank you again for the plugin! Any plans on updating it to the last dwv version?
-
Yes, I’ve just done it! The new version (0.6.0) integrates dwv 0.22.0. See the changelog on the developers page for details. Tell me if you have any troubles.
1079/5000
Hey ivmartel!
I just updated the plugin! Loading images is much faster.
I would like to report an issue that occurred after updating the plugin. Now some javascript files from other plugins are no longer loading on pages and posts where there are dicom support DICOM galleries.
One of the plugins that stopped loading is RoyalSlider – now the sliders no longer load if there is a dicom support gallery on the same page.
I ran a search on the support page of RoyalSlider and they list several possible causes for the problem, but maybe it’s issue number 2 of this link (https://help.dimsemenov.com/kb/wordpress-royalslider-faq/wp-slider -looks-correctly-in-preview-but-when-i-add-it-to-site-it-doesnt-work # 2-you-have-two-jquery-js-scripts-on-one-page). Could you tell if the new version of Dicom Support adds jQuery directly with script tag?
Anyway, I wanted to thank you for updating the plugin! Thank you.
Best regardsI’m happy you like the new version!
About the slider error, the dicom support plugin does not load jquery so I do not think this could be the problem. What could be the problem is that it seems the slicer and dicom plugin depend on another js library called ‘modernizr’. I’ll check this out and keep you posted.
I got carried away, modernizr is probably not the reason for the error… The problem is that RoyalSlider is private, difficult to test it. Do you have a specific error message? Have you checked the browser console window? Could you share a test page?
Hi ivmartel.
This is the errors on the browser console window:
Uncaught TypeError: Modernizr.mq is not a function
at setStickySidebarStatus (db8fab972b8029ff10c2c1726a284099.js timestamp=1512682065:34)
at HTMLDocument.<anonymous> (db8fab972b8029ff10c2c1726a284099.js?timestamp=1512682065:34)
at i (jquery.js?ver=1.12.4:1)
at Object.fireWith [as resolveWith] (jquery.js?ver=1.12.4:1)
at Function.ready (jquery.js?ver=1.12.4:1)
at HTMLDocument.K (jquery.js?ver=1.12.4:1)
db8fab972b8029ff10c2c1726a284099.js?timestamp=1512682065:41Uncaught TypeError: Modernizr.mq is not a function
at a (db8fab972b8029ff10c2c1726a284099.js?timestamp=1512682065:41)
at db8fab972b8029ff10c2c1726a284099.js?timestamp=1512682065:41
at dispatch (jquery.js?ver=1.12.4:1)
at r.handle (jquery.js?ver=1.12.4:1)Maybe the problem is the modernizr.mq …
How can I send you a private message?
thank you
So the problem is modernizr! One solution could be to change its name. I can generate a test plugin for you to try. You can find my email on github.
It would be great! How do I access this test version?
Thank you again!I found a free theme that uses modernizr. I managed to make it work with the dicom plugin by changing the reference to modernizr in the dicom plugin php file. Replace ‘modernizr’ with ‘dwv-modernizr’ in these two lines:
– DicomSupport.php#L178
– DicomSupport.php#L200
Can you tell me if this worked?Hey ivmartel!
I’ve implemented this fix, but it still does not work. I keep getting the following error message in the browser console:Uncaught TypeError: Modernizr.mq is not a function
at setStickySidebarStatus (db8fab972b8029ff10c2c1726a284099.js:34)
at HTMLDocument.<anonymous> (db8fab972b8029ff10c2c1726a284099.js:34)
at i (jquery.js:1)
at Object.fireWith [as resolveWith] (jquery.js:1)
at Function.ready (jquery.js:1)
at HTMLDocument.K (jquery.js:1)
db8fab972b8029ff10c2c1726a284099.js:41 Uncaught TypeError: Modernizr.mq is not a function
at a (db8fab972b8029ff10c2c1726a284099.js:41)
at db8fab972b8029ff10c2c1726a284099.js:41
at dispatch (jquery.js:1)
at r.handle (jquery.js:1)Do you have any idea of another possible solution?
Thank you!Modernizr is a browser feature test library that is usually manually built to fit the tests of your code. The RoyalSlider plugin seems to need different tests than those of the modernizr provided with the DICOM plugin. And it seems that mixing two modernizr.js files does not fix your problem.
Could you share the header of the modernizr.js provided with RoyalSlider, ie the first lines that should include the link to build the library (something that starts with ‘https://modernizr.com/download/?-‘)?
That way I could generate one that has both the tests needed by RoyalSlider and the DICOM plugin.
Sorry, but I searched but couldn’t find what you asked for, so I uploaded de plugin folder to mega for you. All the files there!
https://mega.nz/#F!WNpgnaaB!42Xy_XY8ea5dGG-FYjRgpgThanks, I had a look at the plugin folder and could not find any reference to modernizr, it seems it’s not the culprit… You can delete the data from mega.
So, the next action would be to find who is guilty. One way would be to look at the generated html of the page that gives the error and find the references to modernizr. The one that is not of the dicom plugin should tell which plugin/theme needs it.
It may be that the modernizer has no relation to the problem. I emailed you a link to a page on my site where the problem occurs.
On pages where there is a Royalslider slider and there isn’t a DicomSupport gallery, the Royalslider works normally. On pages where both are present, the Royalslider does not load the slides, and the area in which it should be stays empty.So it seems the one wanting modernizr is the Avada theme. Could you find modernizr.js in its code to confirm? And if so, could you share its header lines to know how it was built?
Here is a link for the Avada theme folder: https://mega.nz/#F!HBBCXZaA!LF0KdmKIk42m9EReRnMfcg
It seems that there is a problem with modernizr in Avada. I looked in support forums and found users reporting compatibility errors between Avada and other gallery plugins, such as Nova Gallery or CCGallery. Apparently, the Avada team has not yet corrected these Modernizr-related errors since 2013.
Here are two forum links that discuss these errors and possible solutions by editing the wordpress functions.php:
– https://theme-fusion.com/forums/topic/ccgallery-wp-avada-theme-issue/
– https://theme-fusion.com/forums/reply/reply-to-nova-gallery-does-not-work-with-avada-theme-15/Even so, I’d like to draw your attention to the fact that the Royalslider error only occurs on pages where DicomSupport is. On pages where there is only the Royalslider, it works (Royalslider works).
Thanks
- The topic ‘Next update!’ is closed to new replies.