Nice plugin but poor form on bundling outdated jQuery plugins

  • While I like the plugin itself, I’m more than a little irate after having spent the last week trying to find the source of an error causing Superfish menu not to function correctly with hoverIntent

    The eventual source of the problem is the bundled version of hoverIntent R5 release in this plugin. WP already bundles R6 so you already risked causing problem and some plugins (like Superfish) are now moving to R7. Better to advise users on how to update hoverIntent themselves to prevent such conflict.

    Easing is also a problem and not necessary anyhow given that later jQuery UI releases have made it redundant (thus the reason it hasn’t been in active development for years now). See this example on JQ UI site for clarification

    jQuery Floater is not needed. I suggest you have a look a latest 2.1.4 Fancybox release for an example of using math to dynamically place the form field either as a floating element or modal layer.

    The concept here is good but I would suggest a complete rewrite without all the conflicting elements. For now I’m going to have to hack the guts out of it and tie the form to Fancybox, much the way WooCommerce does to load the add review form

    https://www.ads-software.com/plugins/slick-contact-forms/

Viewing 1 replies (of 1 total)
  • Thread Starter Stuart-Suits

    (@stuart-suits)

    EDIT to above

    The other option in regards to hoverIntent (and easing if you are intent on keeping it bundled).

    Serve Easing as a separate js file. Wrap the enqueuing in a variable so that if hoverIntent is not already enqueued then load it up. Do the same with Easing but also add a check to see if it is a registered script or not…. only then should the one provided with the plugin be used.

Viewing 1 replies (of 1 total)
  • The topic ‘Nice plugin but poor form on bundling outdated jQuery plugins’ is closed to new replies.