No highres Youtube previews since update 2.9.1

Update: I’ve manually set the quality in the post to “Maximum”. Then Lazyload didn’t work on that post at all anymore. After that I manually set it back to “Default” and chose updated the “Update Posts” option in the LazyLoad settings. Then the Thumbnail was again rendered in full quality.

Something seems random here. Also I need to click on that “Update posts” button after each change to a post, because otherwise LazyLoad refuses to do anything and the video gets embedded as iframe.

• This reply was modified 4 years, 6 months ago by gunther12.

Hi @gunther12, thanks for reporting this so quickly after updating and looking into this. I can confirm that something weird seems to be going on. You already tried the “Update Posts” thing; do you mind trying the following?

Go to your admin panel, enable high-quality videos and save settings, then click “Update Posts”, wait a few seconds, clear your browser cache and go to the post again. Reload the page. Are you now getting a high-quality video? (I tried this using with the Youtube URL from your site and it works for me with a standard WordPress theme using the block editor.)

That other comment about having to click “Update Posts” after each change to a post concerns me… Are you using the block editor or the classic editor? Are you using a plugin to enable the classic editor? Are you using some other editor plugins? What version of WordPress are you using? Does your theme have a non-standard block editor?

@gunther12 Additionally, on your editor page, can you look for the “Youtube thumbnail quality” setting? What value does it show? (default, standard or max) It should be “Default” in order to not overwrite the global thumbnail setting.

It looks like the per-post thumbnail quality overwrite is broken. I’ll look into this in the next hours. (There might still be other issues based on your feedback.)

Hi Kevin, thank you for your fast reply.
I’m using the latest WordPress version. Also the Classic Editor with this plugin: https://www.ads-software.com/plugins/classic-editor/
Youtube Thumbnail Quality on posts is “default” and in the backend of your plugin it’s set to max.

The loss in quality happened since the last update.

The issue that often after editing a post I need to trigger “Update Posts” is something I’m experiencing since a long time. I thought I’ve reported it months ago already.

Max Resolution is always active in the global backend settings, and I’ve done “update posts” multiple times. Still, even on a private browser window, the quality is degraded since the last update, see: https://gwegner.de/know-how/monitor-kalibrieren-spyderx-video/

Let me know, if there is anything else I can contribute.

• This reply was modified 4 years, 6 months ago by gunther12.
• This reply was modified 4 years, 6 months ago by gunther12.

Thanks @gunther12 for the details. We’re talking about three separate problems.

The first one is about the quality of video thumbnails. I just published v2.9.2 which should fix the issue and ensure that blog posts that were updated in the past with the default thumbnail quality properly accept the global default set in the plugin’s admin panel. Can you download the update and confirm that this issue is resolved?

The second issue is that after changing the video thumbnail setting, it takes a few seconds for WordPress to clear the post-specific cache. I can reliably reproduce this by: Opening a blog post, updating the thumbnail setting in a different tab, then _quickly_ reload the blog post in the other tab. If I wait a little longer, this isn’t an issue. I don’t see how I could prevent this as I assume WordPress simply needs a little time to sort things out.

The third issue is that you need to click “Update Posts” after each post update. I’m kind of glad to hear that this has been an issue for a while and it wasn’t introduced by today’s update. I haven’t been able to reproduce the issue yet though, even trying it with the Classic Editor. Unfortunately the issue mentioned before about “wait a few seconds” becomes here even more apparent as it always seems to be an issue whenever I click the preview button of the classic editor. As soon as I reload the page, the video shows up. Is that the case for you as well?

Hi @kevinweber thanks for fixing the latest issue so quickly. I can confirm that with 2.9.2 the quality issue for the previews is gone.

Still, the other (older) issue remains and it’s not related to any WordPress caching from my understanding.

What happens is, that if I change a post with a youtube embed after it has been published, the LazyLoad for Videos feature doesn’t work at all on that post anymore. Even if I clear cache, open that post on a private window or other computer. I only see the original Youtube embed from WordPress.

Then I go in the backend and do Update Posts, which would mostly bring back the desired preview display, but sometimes I need do do this twice to get it going again.

The problem is, this way I cannot know, for which of my hundreds of posts the plugin actually works and for which it doesn’t, which basically gives me no certainty, if I’m complying to the data regulations in the EU regarding direct embeds etc. I’d really love to have this sorted out because your plugin is great otherwise!

BTW: My Youtube embeds are only direct links to Youtube which I place in the text in the classic editor without any further doing.

@gunther12 What does the code look like in the “Text” tab of the classic editor? I’m assuming the Youtube links are correctly placed on their own line, not wrapped by any HTML tags or spaces ([screenshot](https://www.dropbox.com/s/cntods2pwu2w2nw/Screen%20Shot%202020-08-29%20at%2011.46.19%20PM.png?dl=0)). If I try the same, the videos work just fine for me. So I’m wondering what else could be the issue…

The “Update Posts” button works very similar to what should happen whenever you save a post. Therefore my guess is that something doesn’t function properly when you’re saving an individual post. Technically, I’m hooking into the save_post hook. Maybe this doesn’t work? Maybe my hooked-in function doesn’t get called ever, or it takes too long and WordPress aborts it, meaning the internal oembed cache never gets cleared?

A few things you could try. They’re really technical but I can’t help that much more:
1. Disable all other plugins and verify if the issue persists
2. Use a different theme and verify if the issue persists
3. Take this file (https://raw.githubusercontent.com/kevinweber/lazy-load-for-videos/master/src/php/class-register.php) and use it to replace the one on your webspace located in wp-content/plugins/lazy-load-for-videos/src/php/. It’s just slightly different but maybe it helps? Probably not.
4. Debug the code. You can start with this line of code: https://github.com/kevinweber/lazy-load-for-videos/blob/master/src/php/class-register.php#L48, and this one: https://github.com/kevinweber/lazy-load-for-videos/blob/master/src/php/static-update-posts.php#L66

Hi @kevinweber,
I’ve exchanged the class-register.php file with your alternative and since then it works. No matter what I tried, I couldn’t get it to break anymore! I guess that’s very good news! Can you add those changes to the next update, so that it doesn’t break again?

In any case I’ll continue monitoring this and let you know should I experience any strange behavior.

That’s amazing news! Yeah, I already committed that change to the code for a future release. Let me publish an update today – v2.9.3 – to make that fix available for everyone.

Thank you so much! Is there a way to send you a donation to say “Dankesch?n”? Didn’t find anything on your page…

Thanks @gunther12! There’s a donation button on the Lazy Load for Videos WordPress plugin page; here’s the link the donation button would send you to: https://www.kweber.com/donate/LazyLoadVideos/

Perfect, Done!