• Resolved tremlas

    (@tremlas)


    I recently updated simply static from 3.2.5.3 to 3.2.6. One of my pages is at the URL of /feeds. It is NOT a RSS feed but a normal wordpress page (that happens to be a record of feeds I used to follow). With 3.2.6 this page is now omitted from the generated output. I did attempt a generation with the new “generate feeds” option enabled but this didn’t seem to make a difference (the /feeds page was still not included in the generated output).

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author patrickposner

    (@patrickposner)

    Hey @tremlas,

    we indeed added “feed” as a keyword to the excluded list for URLs unless the add feeds option is enabled:

    // Exclude feeds if add_feeds is not true.
    if ( ! $this->options->get( ‘add_feeds’ ) ) {
    $excluded[] = ‘feed’;
    }

    I have to do some testing, to see if it’s still happening if the option is enabled, but you can also remove it yourself with the following filter:

    add_filter(‘ss_excluded_by_default’, function ($excluded) {
    $excluded[] = ‘wp-json’;
    $excluded[] = ‘.php’;
    $excluded[] = ‘debug’;
    return $excluded;
    });

    Thread Starter tremlas

    (@tremlas)

    I tried a generation with your suggested filter at the end of my theme’s functions.php but that didn’t change the result (the /feeds/index.html file is still not present in the resulting zip).

    I also took a look at earlier generations. One from 25th Dec was as I expected. One from 19th Jan (which would have used the 3.2.5.3 version of simply static) gained a /feed/index.html as well as the /feeds/index.html – this contains a redirect to index.xml). Today’s generation contains neither file (to clarify that feed/index.html redirect is not one I’ve created but presumably a standard one from wordpress itself).

    I’m guessing there’s an interaction between the change that (presumably) accidently added the /feed url and the one that removes it.

    Plugin Author patrickposner

    (@patrickposner)

    Hey @tremlas found the problem and fixed it now: https://github.com/Simply-Static/simply-static/commit/2683d7f53759f4218f9a4ed11a42f004daa44fd2

    The filter was implemented too early, so while the code snippet I recommended is the right approach to handling it, it was simply overwritten by the new feed addition. The next update will handle it appropriately.

Viewing 3 replies - 1 through 3 (of 3 total)
  • You must be logged in to reply to this topic.