Non-SVN repo anywhere?

  • cjhaas

    (@chrisvendiadvertisingcom)


    5 months ago

    I would love to help contribute to this, but I hate dealing with SVN. Is there a GitHub or similar repo? We maintain a WP plugin and actually use a GitHub action to publish directly to SVN whenever we need to tag a release.

    Specifically I’d like to address the constructor for Better_image_sizes_resizer which I think should be turned into a singleton. Right now, when calling any of the helper functions such as bis_get_attachment_image_src, they invoke the constructor each time which needlessly re-registers actions each time. I haven’t found any bugs related to this, but it seems like it would be a small performance win.

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author kubiq

    (@kubiq)

    Hi there,

    No, I only use SVN for free WP plugins and only for paid versions I use private GitLab repos.

    Have you actually measured some microtime differences if it really makes sense?

    I can change it of course, thanks for the idea, I’ll have a look at it soon and test it myself, but if you have some test comparisons then I’d be really interested to see them.

    Have a nice day,
    JN

    Thread Starter cjhaas

    (@chrisvendiadvertisingcom)

    We didn’t measure anything, so it is a micro-optimization. And almost all of the hooks registered are in the admin-area, too, whereas the global functions are probably more likely to be used on the public-facing side of things, so an even less of a deal. This just felt like an area that eventually additional future hooks could be added (for whatever reason), so it might be better to nip this in the bud early.

    Thanks for taking this on, btw! We loved Fly and we love that this is almost a drop-in replacement for it! And the focal point feature is a really nice addition.

Viewing 2 replies - 1 through 2 (of 2 total)
  • You must be logged in to reply to this topic.