Not recommended! Unstable code – Riddled with errors
-
I really wanted to like the plugin.
It has a ton of features that could make this a perfect Woocommerce reviews plugin.Plugin code is riddled with errors EVERYWHERE – turn on debug logging and watch the logs fill with errors generated by the plugin.
Tons of PHP warnings (which are a real nuisance when trying to debug our own code), but other PHP errors also.
I eventually had to uninstall, and switch to another plugin which is a real shame.
-
Hi,
Thanks for fixing ‘some’ of the errors. Errors are still occurring on your latest 2.1.3, including a serious one that prevents reviews from being able to be submitted at all when using your shortcode!
The email address field is completely missing (shows a blank area where the field should be) when using your submit review shortcode. Hence now, no reviews can be left at all on our site!
What I had to do to fix it:
Declare the var $Post_Email at line 337 /Shortcodes/SubmitReview.php
$Post_Email = ( isset($_REQUEST['Post_Email']) ) ? esc_attr( $_REQUEST['Post_Email'] ) : '';Then a few lines further down, replace as follows:
//$ReturnString .= "<input type='email' name='Post_Email' id='Post_Email' value='" . isset( $_REQUEST['Post_Email'] ) ? esc_attr( $_REQUEST['Post_Email'] ) : '' . "' required/>"; $ReturnString .= "<input type='email' name='Post_Email' id='Post_Email' value='" . $Post_Email . "' required />";Using isset inline like you had it causes PHP to freak out and not show the email address field (Tested on PHP 7.1 and 7.3 – same result)
See a sample of the errors below – again, please turn on your debug logs when testing! This really should have been caught first time.
[14-Jul-2020 09:35:08 UTC] PHP Notice: Undefined index: Post_Email in \wp-content\plugins\ultimate-reviews\Shortcodes\SubmitReview.php on line 342 [14-Jul-2020 09:39:21 UTC] PHP Notice: Undefined index: Post_Email in \wp-content\plugins\ultimate-reviews\Shortcodes\SubmitReview.php on line 342 [14-Jul-2020 12:43:34 UTC] PHP Notice: Undefined index: Post_Email in \wp-content\plugins\ultimate-reviews\Shortcodes\SubmitReview.php on line 342 [14-Jul-2020 12:58:46 UTC] PHP Notice: Undefined index: Post_Email in \wp-content\plugins\ultimate-reviews\Shortcodes\SubmitReview.php on line 342 [14-Jul-2020 13:03:21 UTC] PHP Notice: Uninitialized string offset: 62 in \wp-content\plugins\ultimate-reviews\Functions\EWD_URP_Submit_Review.php on line 322The Undefined index: Post_Email errors should now go away with my fix.
I’ll leave you to fix the last one.
- The topic ‘Not recommended! Unstable code – Riddled with errors’ is closed to new replies.
