not working for me
-
cookies are still active, no matter what you click. they should be disabled before consent but they are not.
-
hello Rogier, thank you. i have uploaded new version.
after accepting cookies (or clicking on video elements) video objects become active as expected. but after reloading the page video objects are still missing.
I noticed that it works when you resize the window, so there still was a race condition. I’ve now changed the approach. This keeps checking until it runs, which should fix any race conditions.
Let me know if this one fixes it!
https://github.com/Really-Simple-Plugins/complianz-gdpr/tree/wordpress-video-shortcode
hello, new version uploaded. but it still does not work.
Sorry for all the iterations, but it works just slightly different on your site, because of loading order. On my test environment it already works fine. But I think we’re almost there.
I’ve made a small change, and added a lot of logging so I can see exactly what happens. If this one doesn’t fix it, I think I should be able to see what the order of loading is, and work out a solution.
https://github.com/Really-Simple-Plugins/complianz-gdpr/tree/wordpress-video-shortcode
dont worry no problem. it is ok for me.
new version is uploaded. feel free to test it. but i think it still does not work.
thank you for your help
I see that the function which checks if the video activation should run never starts on your site. So I’ve completely separated this code, so it doesn’t wait for the cookiebanner event listener.
https://github.com/Really-Simple-Plugins/complianz-gdpr/tree/wordpress-video-shortcode
Let me know when you’ve installed it, then I can check how it runs.
hello Rogier, just uploaded new version. did not test it properly yet (it is saturday lol) but it looks like it is working now. if you have time you can test it and confirm. thank you for your help. have a nice weekend.
Hi @stclaus, yes, looks good!
Thanks for confirming!
hello Rogier,
sorry for a delay – easter holiday.
i have a question. is it safe to use complianz plugin with wp-optimize plugin? i mean minify and cache page.
it looks i have found some issue but i cant replicate it properly yet.
thank you for your answer and have a nice day
Hi @stclaus,
The plugin should work fine in combination with WP Optimize and other optimization tools.
If you do happen to run into any unexpected behavior with a specific optimization in the WP Optimize plugin enabled, you can always exclude Complianz from that feature by adding “complianz.js” and “complianz.min.js” to the exclusion list (https://getwpo.com/faqs/category/minification/#How-do-I-exclude-individual-JavaScript-scripts-from-being-minified-and-merged-).
Kind regards,
Jarnohello @jarnovos , thank you for your reply. i understand.
hello @rogierlankhorst ,
here is the issue:
1. i run the page (mojkouc.com) – no wp-optimize active
2. i have cookies cleared, so i see cookie notification banner
3. i close it (i can activate videos by clicking on them)
4. i click on vimeo video object
5. vimeo video object will not become active (youtube objects are behaving ok)
6. reloading page does not change the behaviour (vimeo object is not active. youtube objects are)i have another questions:
1. on pc when i close cookie banner – it minimizes. but on mobile phone it disappears and there is no way how to show it again. is this behaviour correct?
2. is this custom update (you created for me) part of the official plugin already?thank you for your time and answer
have a nice day
Hi @stclaus,
Thanks for reporting it, you’re right. I discovered that while I tested with consent per service, with consent per category (as you have active currently), the activation for statistics (which is what vimeo is categorised in) does not work properly.
Vimeo has been moved to statistics only recently, so this is a very new feature, not released in production yet.
This one works for me with consent per category:
https://github.com/Really-Simple-Plugins/complianz-gdpr/tree/wordpress-video-shortcodehello Rogier,
yes, it seems it is working for me too.
for now i do not recognize another issues. so thank you for your help and cooperation.
have a nice day
- The topic ‘not working for me’ is closed to new replies.