• bugs happen sometimes, but the real difference is in the developer support and willing to repair them. This plugin works as a charm, do exactly what it promises, and the minor bugs, that were found were quickly solved. Thumbs up

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author doublesharp

    (@doublesharp)

    These should all be fixed here: https://www.dropbox.com/s/o775s22b7ewyun7/validated-field-for-acf.zip?dl=1

    Not sure if a 2 star review of a free plugin is warranted based on having all the debug settings on but if you think that’s fair… I would consider this a bug and not something to review the functionality on.

    Thread Starter thomask

    (@thomask)

    Hi DoubleSharp. First let me thank you for your plugin as it is otherwise great.
    The two stars are not for the plugin quality, but for making a plugin without debug testing, what is a basic, that should be by every plugin author. Not just because it helps reveal the errors, but also using deprecated functions, that may destroy the website completely when wordpress is updated (and remember – today the wordpress can update even without user interaction). That’s why wise wp developers always use scripts, that do not produce warnings. I’m going to try your fixed version and i will eventualy update my review to 5 stars ??

    Thread Starter thomask

    (@thomask)

    it now throws theese error notices in ACF

    Notice: Undefined index: class in /home/www/groupeseb-download.cz/www/groupeseb-download.cz/wp-content/plugins/advanced-custom-fields-pro/fields/text.php on line 103

    Notice: Undefined index: readonly in /home/www/groupeseb-download.cz/www/groupeseb-download.cz/wp-content/plugins/advanced-custom-fields-pro/fields/text.php on line 111

    Notice: Undefined index: disabled in /home/www/groupeseb-download.cz/www/groupeseb-download.cz/wp-content/plugins/advanced-custom-fields-pro/fields/text.php on line 111

    otherwise it works. Seems like some not optional fields for acf render_fields (what should be imo reported to acf, as they should probably have some defaults and do not throw error notices).

    Plugin Author doublesharp

    (@doublesharp)

    That is just the text field type, this might occur with others as well. I’m guessing ACF isn’t expecting me to jump in the middle of the config and those those will be available but it might be hard to know what all the different fields types are expected, especially as some of them are plugins.

    Sorry for the issues, I wrote the ACF 5 update when I was pretty sick with the flu. FWIW the WordPress auto updates will only happen on minor versions, and deprecated code is only removed in major versions, so this wouldn’t break on auto update. That said, I already updated it to use the new function in $wpdb.

    I’ll see if I can figure out a better solution tonight for the missing ACF parent fields (probably just loop through and copy all of the sub fields, but that might have some negative effects as well).

    Plugin Author doublesharp

    (@doublesharp)

    @thomask can you give this one a try, i think i have it all cleaned up now: https://www.dropbox.com/s/o775s22b7ewyun7/validated-field-for-acf.zip?dl=1

    Thread Starter thomask

    (@thomask)

    I have tried it, but not it does not work at all – the field isn’t saved now (even with debug off). Also when i change it back to text, it wrongly keeps the old rows in ACF (but they disapear after field save).

    Plugin Author doublesharp

    (@doublesharp)

    Ugh, this is what happens when you chop wood all day and then try to fix bugs at night ??

    Sorry about that, I “cleaned” up the code right before I created the zip and accidentally removed “value” from the fields that are copied… so it didn’t have access to the value to save it. Updated the zip if you could try again: https://www.dropbox.com/s/o775s22b7ewyun7/validated-field-for-acf.zip?dl=1

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘works as charm with perfect developer support’ is closed to new replies.