• Resolved jave.web

    (@javeweb)


    Hi,
    currently we are getting following notice on the search page, but only when there are no results found …

    Notice: Trying to get property ‘ID’ of non-object in /wp/hosting/path/wp-content/plugins/ultimate-member/includes/core/class-access.php on line 703

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Contributor Champ Camba

    (@champsupertramp)

    Hi @javeweb

    Could you please try this pre-release version 2.2.3?
    https://downloads.www.ads-software.com/plugin/ultimate-member.2.2.3-beta.zip

    Please ensure that you’ve created a backup of your site before you update it.

    Let us know if you’re still encountering issues after the update.

    Regards,

    Plugin Contributor Champ Camba

    (@champsupertramp)

    Hey there!

    This thread has been inactive for a while so we’re going to go ahead and mark it Resolved.

    Please feel free to re-open this thread by changing the Topic Status to ‘Not Resolved’ if any other questions come up and we’d be happy to help. ??

    Regards,

    Thread Starter jave.web

    (@javeweb)

    Well …
    I can’t test a pre-release version on a web with a lot of users.
    However,
    I did check the code and I see you’ve added empty($post) check to the problematic function get_post_privacy_settings.
    Even though this may resolve this specific issue in particular, it’s not a proper check.
    The proper check should be
    is_numeric($post) || (is_object($post) && ($post instanceof WP_Post))

    Optionally you can also drop the is_object and just test the instanceof only – according to PHP docs: “instanceof does not throw any error if the variable being tested is not an object, it simply returns false. Constants, however, were not allowed prior to PHP 7.3.0.”

    But this is the only sure way to determinate you’re really accessing a WP_Post.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Notice on search page when nothing found’ is closed to new replies.