Viewing 9 replies - 1 through 9 (of 9 total)
  • Thread Starter Ray Hollister

    (@rayhollister)

    Actually, this might be even better: https://github.com/coryasilva/Leaflet.ExtraMarkers

    Plugin Author hupe13

    (@hupe13)

    I’ll take a look at it.

    Plugin Author hupe13

    (@hupe13)

    Thread Starter Ray Hollister

    (@rayhollister)

    That is awesome. Thank you so much!

    Sadly this only gets me about halfway to what I need. Of course, I made the mistake of assuming the extramarkers would be backwards compatible with the same features that leaflet-marker has, specifically being able to put an address in the shortcode and putting HTMl in the description. I’m guessing that Extra Markers would have to be changed to get those to work, right?

    Plugin Author hupe13

    (@hupe13)

    HTML in description – you mean e.g. a Link? This seems a bug, thank you very much for testing. What else are you missing?

    Thread Starter Ray Hollister

    (@rayhollister)

    Yep, links break it. I will confirm, but I think even <strong> or <em> breaks it.

    • This reply was modified 2 years, 2 months ago by Ray Hollister.
    Thread Starter Ray Hollister

    (@rayhollister)

    Seriously, thank you!

    Here’s two examples:
    This one is working, but the description is not bold even though it is in a <strong> tag.

    https://porchfest-wjct.pantheonsite.io/jaxmusic/extra-marker-test/

    Here’s the shortcode I used:

    [leaflet-map lat=29.871672082404032 lng=-81.29361038423357 height=600 zoom=13 detect-retina fitbounds zoomcontrol scrollwheel tileurl=https://stamen-tiles.a.ssl.fastly.net/toner/{z}/{x}/{y}.png attribution='Map tiles by <a href="https://stamen.com">Stamen Design</a>, under <a href="https://creativecommons.org/licenses/by/3.0">CC BY 3.0</a>. Data by <a href="https://openstreetmap.org">OpenStreetMap</a>, under <a href="https://www.openstreetmap.org/copyright">ODbL</a>.']
    [extramarker lat=29.871672082404032 lng=-81.29361038423357 markerColor=purple shape=circle icon=fa-number number=1]<strong>Test 1</strong>[/extramarker]
    [extramarker lat=29.892448944865485 lng=-81.31283436952994 markerColor=purple shape=circle icon=fa-number number=2]<strong>Test 2</strong>[/extramarker]
    [cluster]
    [fullscreen]
    [zoomhomemap fit/!fit]

    Here’s the second example. It is breaking. The only difference is I put in <a href="/jaxmusic/">Test 1</a> in the description.
    https://porchfest-wjct.pantheonsite.io/jaxmusic/extra-marker-test-2/

    Here’s the shortcode I used for it:

    [leaflet-map lat=29.871672082404032 lng=-81.29361038423357 height=600 zoom=13 detect-retina fitbounds zoomcontrol scrollwheel tileurl=https://stamen-tiles.a.ssl.fastly.net/toner/{z}/{x}/{y}.png attribution='Map tiles by <a href="https://stamen.com">Stamen Design</a>, under <a href="https://creativecommons.org/licenses/by/3.0">CC BY 3.0</a>. Data by <a href="https://openstreetmap.org">OpenStreetMap</a>, under <a href="https://www.openstreetmap.org/copyright">ODbL</a>.']
    [extramarker lat=29.871672082404032 lng=-81.29361038423357 markerColor=purple shape=circle icon=fa-number number=1]<a href="/jaxmusic/">Test 1</a>[/extramarker]
    [extramarker lat=29.892448944865485 lng=-81.31283436952994 markerColor=purple shape=circle icon=fa-number number=2]<strong>Test 2</strong>[/extramarker]
    [cluster]
    [fullscreen]
    [zoomhomemap fit/!fit]

    [extramarker] also breaks and gives the same error if there is a linebreak in the description.

    Here’s the error it’s kicking out:
    Fatal error: Uncaught RuntimeException: Unclosed string at position: 687 in /code/wp-content/plugins/extensions-leaflet-map-github-main/pkg/JShrink/Minifier.php:500 Stack trace: #0 /code/wp-content/plugins/extensions-leaflet-map-github-main/pkg/JShrink/Minifier.php(258): JShrink\Minifier->saveString() #1 /code/wp-content/plugins/extensions-leaflet-map-github-main/pkg/JShrink/Minifier.php(154): JShrink\Minifier->loop() #2 /code/wp-content/plugins/extensions-leaflet-map-github-main/pkg/JShrink/Minifier.php(122): JShrink\Minifier->minifyDirectToOutput('\r\n

    • This reply was modified 2 years, 2 months ago by Ray Hollister. Reason: adding the error message
    Plugin Author hupe13

    (@hupe13)

    Now the Github version should work.
    You should use:
    [leflet-map fitbounds ....]
    and
    [zoomhomemap fit]
    or
    [zoomhomemap !fit]
    I have tried to document how fitbounds and fit work: https://leafext.de/en/doku/zoomhome/ . For marker is it better, you use leaflet-map fitbounds.

    • This reply was modified 2 years, 2 months ago by hupe13.
    Plugin Author hupe13

    (@hupe13)

    Published in version 3.2.

Viewing 9 replies - 1 through 9 (of 9 total)
  • The topic ‘Numeric Markers’ is closed to new replies.