• Resolved sofianosorthopedika

    (@sofianosorthopedika)


    Hello!

    Under 768px you will see i am using your plugin for opening a offcanvas panel for my filters with the trigger element on the right with these css classes “ocs-trigger ocs-toggle ocs-toggle-filters-offcanvas offcanvas-flyout-open”.

    I also have this element,
    <button data-nav=”site-navigation” class=”menu-toggle” aria-controls=”primary-menu” aria-expanded=”false”>

    as a trigger from my generatepress theme to open my menu as off canvas panel.

    When i activate your plugin and my custom offcanvas panel works, the generatepress offcanvas menu trigger wont work correctly…

    Actually if you click the generatepress trigger, nothing will happen.
    But if you click the generatepress trigger and then the custom trigger i made for your plugin it opens both offcanvas panels.

    I want to open each one on its own.

    My current plugin settings

    View post on imgur.com

    Maybe this is somekind of bug?

    The page I need help with: [log in to see the link]

Viewing 9 replies - 1 through 9 (of 9 total)
  • Plugin Author Jory Hogeveen

    (@keraweb)

    Hi @sofianosorthopedika

    My first guess would be that the off canvas implementation of GeneratePress isn’t compatible with this plugin.
    By default this plugin is using Slidebars which implements CSS3 transform properties for performance.
    If you enable “Legacy CSS” in the plugin settings it will revert to plain CSS2 properties which are more compatible.

    Cheers, Jory

    Thread Starter sofianosorthopedika

    (@sofianosorthopedika)

    Hello!

    I just enabled it, and no change, i still get the same behavior.
    Is there anything else i could try?

    Plugin Author Jory Hogeveen

    (@keraweb)

    Hi @sofianosorthopedika

    I do see a change. Now if I click on the menu icon on the top left a small menu opens with 2 items on it.

    Cheers, Jory

    Thread Starter sofianosorthopedika

    (@sofianosorthopedika)

    Hello! Please check my site again!

    I managed with the help from my theme support to add the necessary class to the theme’s menu toggle…

    So with the menu toggle up left on mobile i managed to open a second offcanvas menu.

    But i have 2 problems…

    1. the trigger is working only if i select slide in panel (overlay isnt working), maybe cause i am using overlay for my filters offcanvas menu

    2. whatever i put inside the offcanvas panel in widgets, it wont be shown inside the panel in the frontend

    View post on imgur.com

    Plugin Author Jory Hogeveen

    (@keraweb)

    Hi @sofianosorthopedika

    I now see that you’ve changed the menu icon indeed. But the off canvas sidebar you are trying to trigger isn’t rendered on the page.

    Could you share your full configuration (and all sidebar configurations)?

    Are you doing any custom code as well?

    Cheers, Jory

    Thread Starter sofianosorthopedika

    (@sofianosorthopedika)

    Hey, the only custom code i used is from my theme support to add a css class to the theme’s menu trigger.

    The code to do that was

    //add css class to toggle
    add_filter( 'generate_parse_attr', function( $attributes, $context ) {
        if ( 'menu-toggle' === $context ) {
            $attributes['class'] .= 'ocs-toggle-menu-offcanvas';
        }
    
        return $attributes;
    }, 10, 2 );

    Here are my settings

    offcanvas

    I also tried with a custom trigger of mine and not the theme’s menu trigger and i got the same behavior, with no content inside the slide in panel….

    Plugin Author Jory Hogeveen

    (@keraweb)

    Hi @sofianosorthopedika

    I think I’ve found the issue.

    Both sidebars are rendered on the page, but the menu-offcanvas is renderd INSIDE the filters-offcanvas.
    This is related to incorrect HTML inside the filters sidebar.

    If I look at the source code I even see <?php in the rendered code. Please check your block widgets for errors or maybe even re-create them completely.

    Cheers, Jory

    Thread Starter sofianosorthopedika

    (@sofianosorthopedika)

    You are the best! I am gonna leave a review for the great plugin and author!

    Plugin Author Jory Hogeveen

    (@keraweb)

    Hi @sofianosorthopedika

    Glad that the issue has been resolved and thank you for your review!

    Cheers, Jory

Viewing 9 replies - 1 through 9 (of 9 total)
  • The topic ‘Off canvas menu of my theme wont work’ is closed to new replies.