Viewing 9 replies - 1 through 9 (of 9 total)
  • Plugin Author Daniel Iser

    (@danieliser)

    @lupach I think I know what is happening. Officially support for archives is not quite there. Will try to get it added to the next release. In the mean time you can use the popmake_popup_is_loadable filter like so.

    function mycustom_popup_is_loadable( $is_loadable, $popup_id ) {
    	if( $popup_id == 123 ) {
    		return true;
    	}
    	return $is_loadable;
    }
    add_filter('popmake_popup_is_loadable', 'mycustom_popup_is_loadable' );
    Thread Starter lupach

    (@lupach)

    hello danieliser, I tried your suggestion but no luck.
    I copied the code into the functions.php file (with my popup id) and I got an error, that the 2nd argument of the function is missing, So I went ahead and forced the popup_id in the function like so

    function mycustom_popup_is_loadable($is_loadable, $popup_id=1516) {
    	if( $popup_id == 1516 ) {
    		return true;
    	}
    	return $is_loadable;
    }
    add_filter('popmake_popup_is_loadable', 'mycustom_popup_is_loadable' );

    and the error goes away.
    But then it starts to act funny, when I open the page it pops another popup I made with popup maker (which has an id of 1977). but it only flashes for a couple of seconds and then goes away.
    and the button in the menu still doesn’t work

    Plugin Author Daniel Iser

    (@danieliser)

    @lupach – Sorry my fault yours should actually look like this.

    function mycustom_popup_is_loadable( $is_loadable, $popup_id ) {
    	if( $popup_id == 1516 ) {
    		return true;
    	}
    	return $is_loadable;
    }
    add_filter('popmake_popup_is_loadable', 'mycustom_popup_is_loadable', 10, 2 );
    Thread Starter lupach

    (@lupach)

    @danieliser – Dont worry, I made the changes and I still got the error, then I realized I wasnt using the latest version so I upgraded and now I dont get the error but the pop up keeps not appearing. it’s the only place in the site where it doesnt show up, albeit, the most important one

    Plugin Author Daniel Iser

    (@danieliser)

    @lupach – Even with the updated function above? The original function I gave you was flawed.

    You could also change the value of , 10, 2 at the end to , 1000, 2 which may have an effect if there is another filter there.

    Thread Starter lupach

    (@lupach)

    @danieliser – Yes even with the updated functions, right now it looks like this

    function mycustom_popup_is_loadable( $is_loadable, $popup_id) {
    	if( $popup_id == 1516 ) {
    		return true;
    	}
    	return $is_loadable;
    }
    add_filter('popmake_popup_is_loadable', 'mycustom_popup_is_loadable', 1000, 2 );

    and it just doesnt do anything.
    I am doing the call through a class in the menu button, and it works on the rest of the pages.

    Plugin Author Daniel Iser

    (@danieliser)

    Is https://vif.com.mx/indice/anio/2014/?continente=america the link in question still? Your popup is loaded on that page, although I cannot find any menu items or any other element on the page that has the popmake-1516 class on it. I see that your using custom selectors, you may try adding the popmake-1516 class instead of the videox class just to rule out any potential bugs.

    The popup opens using the console by command line, so there are no JS errors preventing it from working.

    Thread Starter lupach

    (@lupach)

    great it now works perfectly. I changed it to popmake-1516 and now it works, I changed it again to videox and works again, Im baffled, but it works, thank you!

    Plugin Author Daniel Iser

    (@danieliser)

    @lupach Strange, not sure why it wasn’t working to begin with, unless the WPMU plugin was interfering somehow or even showing on top of it.

    Glad you got it working.

    Please take a moment to rate and review the plugin and or support.

Viewing 9 replies - 1 through 9 (of 9 total)
  • The topic ‘Opening on a taxonomy page’ is closed to new replies.