Outdated Fancybox script

@tyrannous – We’re not seeing any problems with any of the Lightbox libraries we include as a convenience. Although it may be a deprecated function you are noting, we are not seeing anything specifically to indicate it is a problem.

Thanks!

– Cais.

@imagely,
thanks for getting back to me.

Well the thing is, on one of my client’s (old) sites I’m getting a Uncaught TypeError: Cannot read property 'msie' of undefined in path/to/plugins/nextgen-gallery/products/photocrati_nextgen/modules/lightbox/static/fancybox/jquery.fancybox-1.3.4.pack.js?ver=2.2.14. This causes a Uncaught TypeError: e.fancybox is not a function in path/to/plugins/nextgen-gallery/products/photocrati_nextgen/modules/lightbox/static/fancybox/nextgen_fancybox_init.min.js?ver=2.2.14.

The site runs a modified Twenty Twelve theme (no JS modifications) and the error occurs even with all other plugins deactivated. You may want to take a look: https://steinmetz-riesa.de/innenausbau/ (I’m going to fix the error in a few days by patching the script to keep the “Fancybox downtime” as short as possible).

In my opinion, there’s really no reason to not update the Fancybox script.
I’d really appreciate if you could reconsider your opinion on this.

Thanks!

@tyrannous – We are looking at what bundled scripts (especially Lightbox libraries as they are only included as a convenience) to continue on with. Updates are always something to be considered although the root cause of this particular issue has still to be defined. The reference to msie has been seen although not specifically linked to anything in particular as it does not appear on every instance.

Thanks for your further input.

– Cais.

Is there anything I can do to speed things up?

In my opinion, since you decided one day to include lightbox libraries, you are responsible for keeping them up to date.

And if you don’t want to update fancybox (which should be done quickly since the initialization code hasn’t changed and you basically just need to replace the files) you better remove it completely.

Thanks.

@tyrannous – Removing these Lightbox libraries we include as a convenience has always been an option we consider.

You are also not required to use any of the bundled Lightbox libraries. If you wish to use a different one you need only configure the Lightbox Effect|Custom option appropriately per the Lightbox library’s documentation.

Thanks!

– Cais.

I’m experiencing the same issue as well.
Do you have an idea about when this will be handled?

Thanks.

@juleb – Please start your own topic so we can try to help you with your specific issue on your specific site.

See https://make.www.ads-software.com/support/handbook/forum-welcome/#post-in-the-best-place

Thanks!

– Cais.

@juleb,
don’t waste your time on a new support ticket. All @imagely is going to tell you is they don’t know whether they will keep the bundled lightbox scripts.

They probably spend more time telling this to their users as they would need to update the scripts …

@tyrannous – We are reviewing some of the libraries we currently use to see if/when would be best to update (and refactor our code base as needed).

– Cais.

Cais, your company seems to be seriously slow in decision making given the fact that you keep telling me the same statement for 2,5 months now.

Why don’t you include an updated Fancybox script to fix the mentioned errors as a start and refactore your code downstream? As far as I know, the required HTML markup hasn’t changed for newer versions.

It’s like talking to a brick wall.

@tyrannous – Our review of the two libraries show differences to the extent we would have to consider a complete refactoring to change the library or add another library (Fancybox 3) to accommodate its usage.

Thanks!

– Cais.

I habe the same problem.
The jquery.fancybox-1.3.4.css and jquery.fancybox-1.3.4.pack.js are old.
I have a lot of warings and false.
I was traying so much thins.
Now I have installed the Photo Gallery plugin.

Uncaught TypeError: Cannot read property ‘msie’ of undefined
at jquery.fancybox-1.3.4.pack.js:18
at jquery.fancybox-1.3.4.pack.js:46
jquery.min.js:2 jQuery.Deferred exception: $(…).unload is not a function TypeError: $(…).unload is not a function
at HTMLDocument.<anonymous> (https://localhost:8888/moviment/wp-content/plugins/nextgen-gallery/products/photocrati_nextgen/modules/ajax/static/ajax.min.js:51:11)
at l (https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js:2:29375)
at c (https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js:2:29677) undefined
w.Deferred.exceptionHook @ jquery.min.js:2
jquery.dotdotdot-1.5.7-packed.js:15 dotdotdot: No element found for “undefined”.
jquery.min.js:2 jQuery.Deferred exception: e.fancybox is not a function TypeError: e.fancybox is not a function
at e (https://localhost:8888/moviment/wp-content/plugins/nextgen-gallery/products/photocrati_nextgen/modules/lightbox/static/fancybox/nextgen_fancybox_init.min.js:1:100)
at HTMLDocument.<anonymous> (https://localhost:8888/moviment/wp-content/plugins/nextgen-gallery/products/photocrati_nextgen/modules/lightbox/static/fancybox/nextgen_fancybox_init.min.js:1:228)
at l (https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js:2:29375)
at c (https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js:2:29677) undefined
w.Deferred.exceptionHook @ jquery.min.js:2
jquery.min.js:2 Uncaught TypeError: $(…).unload is not a function
at HTMLDocument.<anonymous> (ajax.min.js:51)
at l (jquery.min.js:2)
at c (jquery.min.js:2)
jquery.min.js:2 Uncaught TypeError: e.fancybox is not a function
at e (nextgen_fancybox_init.min.js:1)
at HTMLDocument.<anonymous> (nextgen_fancybox_init.min.js:1)
at l (jquery.min.js:2)
at c (jquery.min.js:2)

@brida – A response to the bug report you submitted has been made.

– Cais.

Every think works now. The problem was, that I have the import from jQuery (v.3.3.1) in my program. With the NexGEN Plugin have the jQuery (v.1.12.4).
I have two different version. I deleted my include from jQuery and now it works find. Thanks

@brida – Thanks for the update.

– Cais.