PgCache_ContentGrabber not checking for uncompressed cache

mhh i have investigate… on line 237:

/**
* Check if page is cached
*/
if ( !$this->_set_extract_page_key( $mobile_group, $referrer_group, $encryption, $compression, '', $with_filter ) ) {
   $data = null;
} else { 
    $data = $cache->get_with_old( $this->_page_key, $group );
    list( $data, $this->_old_exists ) = $data;
}

instead on line 249:

if ( $this->_set_extract_page_key( $mobile_group, $referrer_group, $encryption, false, '', $with_filter ) ) {
    $data = null;
} else {
    $data = $cache->get_with_old( $this->_page_key );
    list( $data, $this->_old_exists ) = $data;
    $compression = false;
}

it seems the opposite check!

Yes, that’s right – there seems to be a typo / mistake as the ! is missing at the start of the if condition on line 249. Adding the ! will give the correct behaviour.

(The first check on ln 237 is for the compressed page, the sceond check on ln 249 for the uncompressed page).

ok, on unofficial version of W3 Total Cache we have add a fix https://github.com/szepeviktor/w3-total-cache-fixed/pull/268

hello nigro
can you tell us why every change is done in community version why it is not updated to actual forum
Appreciate your response
Thanks

Hi, W3 Total Cache and W3 Total Cache Fixed (also known as “community version”) are two different projects managed and developed by different persons without any connection. I don’t know why W3 Total Cache lack in updates.

My 5 cents: the developer behind W3 Total Cache, know our project, sometime i send a message for inform on my bug fix, he never respond me. W3 Total Cache it’s free (users pay only for support), but developers don’t works free, it’s hard mantain a business with milion of “free” users, i think this is the cause for the lack of updates: new updates require money; but this is only my speculation, i don’t know anything.

I’m only a fan of W3TC, with a bit of free time. End of story.

Thanks for your reply nigro
i understand but if they are unable to provide forum updates then they have to mentioned something.