PHP 7.3 Support (PHP Deprecated: strpos())

Well, technically those are not errors, but rather warnings that strpos will not work a certain way at a later PHP-version so for now you can safely ignore. in the mean time I’ll look into this ??

frank

Thanks Frank

question; does the warning also point to other lines in autoptimizeExtra.php or to other files?

if so; can you mail me an excerpt of your php-errorlog to futtta-at-gmail-dot-com?

It’s just the line 161 of autoptimizeExtra.php

I’ve sent you the log.

OK, I have a (presumed) fix in the Github-version, could you download AO 2.5.1-beta here and take it out for a spin to confirm all is well?

thanks!
frank

Now getting

 FastCGI sent in stderr: "PHP message: PHP Warning: strpos(): Empty needle in
/var/www/domain.com/html/wp-content/plugins/autoptimize/classes/autoptimizeExtra.php on line 162

how bizarre, I don’t see how a non-string or after casting empty string would end up there. but I’ll add an extra check, give me a second ??

OK, more checks in, can you re-download and test the beta? ??

That commit seems to do the trick.

OK, that will be in AO 2.5.1 out later this month ??