PHP 8.1 compatability

There seems to be mainly two incompatabilities:
* SV_WC_DateTime::getTimestamp() signature must match \DateTime::getTimestamp()
* FILTER_SANITIZE_STRING has been deprecated. Is it not possible to use FILTER_SANITIZE_SPECIAL_CHARS or FILTER_SANITIZE_FULL_SPECIAL_CHARS instead anyway?

• This reply was modified 1 year, 8 months ago by tbrmilesson.

Hi there!

Thank you so much for using our Sequential Order Numbers plugin. I’d be happy to help with this!

Could you please clarify if those 2 PHP logs are Errors, Notices, or Warnings?

Also, could you let me know if the plugin is having any unexpected behaviors or obvious issues with functioning?

• This reply was modified 1 year, 8 months ago by jlareauxskyverge.

I can confirm that the logs are notices and there are (what I can tell!) no side effects per se.
There are _a lot_ of notices though and it makes it hard to debug other issues since it’s so spammy.

?Hey there,

Thank you so much for letting me know the type of error you’re seeing.
?
?I can appreciate that debugging other plugins can get difficult with a lot of notices and warnings flooding the log.
?
?Adjusting the error reporting level to report warnings and above may clear up your log files ??
?
?Can you let me know if you are needing PHP error reporting at the most verbose level?

Thank you!

Hi, sorry for late reply.

Logging notices is important for us as we don’t ship anything with notices. We do not have error reporting on in production environments, but we do in development and staging to pick up on issues.
Sequential Order Numbers for WooCommerce absolutely fills our error logs since every request generates a lot of notices.

Regards,
Rasmus Milesson

Hey @tbrmilesson ,

Thank you for clarifying that you log notices. I tested Sequential Order Notices in a test environment using PHP 8.1. I was unable to replicate any PHP notices or warnings. I have seen other plugins sometimes modify our plugin’s behaviors and cause PHP notices or warnings.

As a next step, could you please try disabling all your plugins except for WooCommerce and Sequential Order Numbers and then let me know if the PHP notices persist? If this fixes the issue, you can try re-enabling your plugins one by one to rule out a potential plugin conflict.

Could you please let me know how this test goes?

Thank you,

Hey @tbrmilesson ,

It has been a long time since we heard from you, so I’m going to mark this topic as resolved.

If you’re still experiencing issues please take a look at our FAQs for more information and create a new thread if you have further questions.

Thanks,
Jessica ??

@jessicaskyverge

Hi,

This is a problem for sure, running php 8.1+ and it is not due to any plugin modifications.

Deprecated: Return type of SkyVerge\WooCommerce\PluginFramework\v5_10_12\SV_WC_DateTime::getTimestamp() should either be compatible with DateTime::getTimestamp(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in?wp-content/plugins/woocommerce-sequential-order-numbers-pro/vendor/skyverge/wc-plugin-framework/woocommerce/compatibility/class-sv-wc-datetime.php?on line?85

Would be really great if this could be resolved. Thank you!

Hey there,

Amber here, filling in for Jessica & Jesse. My apologies that you are still having this notice. Is this happening in a production environment?

All the best,

Amber SkyVerge