PHP 8.x compat issue

  • Howdy! I’m working on a large migration from PHP 7.x to PHP 8.x and an issue with Geo Mashup’s use of mktime() popped up. I haven’t actually gone through steps to trigger the error, but it does seem like a clear issue when reading the code.

    In geo_mashup_edit_form(), when no location object is available, the location date time is set to mktime(). Since PHP 5.1, the use of mktime() without an hour parameter has been deprecated. In PHP 8.0, it has been removed and will cause a fatal error.

    I think the correct replacement here is just time() to get the current Unix timestamp.

    Thanks!

  • You must be logged in to reply to this topic.