• Since activating the latest update, searches seem to be taking a bit longer than before. Query Monitor produces the following notices when a search is run:

    Undefined variable: query_join
    wp-content/plugins/relevanssi/lib/search.php:468
    
    Undefined property: WP_Query::$post
    wp-includes/query.php:3960

    I know they aren’t serious, but I wondered whether they might be the cause for the extra time taken in searching.

    https://www.ads-software.com/plugins/relevanssi/

Viewing 3 replies - 1 through 3 (of 3 total)
  • I can confirm the former, but not the latter.
    My site is set up to display all errors, so this actually appeared for me on the site as well.
    It is a simple fix at line 468 — a variable that is not always initialized. The danger of “if” without curly braces!

    Confirmed as well. Can we get a hotfix, Mikko? =)

    Plugin Author Mikko Saari

    (@msaari)

    For a quick fix, add

    $query_join = "";

    as line 467. I’ll release a fixed version soon.

    As for the searches taking longer, this small error should have no effect on that. None of the changes should really effect the search power, so I think it’s probably random fluctuation.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘PHP Notices’ is closed to new replies.