PHP warning in package.module.nextgen_basic_singlepic.php

  • Resolved TiKu

    (@tiku)


    6 years, 3 months ago

    Hi,

    In line 35 of products/photocrati_nextgen/modules/nextgen_basic_singlepic/package.module.nextgen_basic_singlepic.php, you’ll find this code:
    $image = array_shift($displayed_gallery->get_entities(1, FALSE, FALSE, 'included'));
    This causes the warning “Only variables should be passed by reference”.

    I think the code should be changed to storing the return value of get_entities into a temporary variable and pass this variable to array_shift.

    Best regards
    TiKu

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Contributor Imagely

    (@imagely)

    Hi Tiku,

    Sorry to hear about the encountered issue. I think that it may be specific to the PHP version you are using, Can you please let us know what PHP version are you currently using for your site?

    Thanks,
    Mihai

    Thread Starter TiKu

    (@tiku)

    Should be version 7.0.31.

    Plugin Contributor Imagely

    (@imagely)

    Hi @tiku!

    Would you mind rolling back to v5.6 PHP and let us know if that clears the error you’re seeing?

    Thanks! ??
    Becky

    Thread Starter TiKu

    (@tiku)

    Hi @becky!

    I cannot rollback this installation to v5.6 as this is a production system. But I have found out that the warning is related to PHP Strict Standards. So I guess you won’t see it in standard mode. See here – it is the same problem: https://php.net/manual/de/function.array-pop.php#114501

    Best regards
    TiKu

    Plugin Contributor Imagely

    (@imagely)

    Hi TiKu,

    Absolutely. Turning off the PHP Strict Standards should help with this.

    Mihai

    Thread Starter TiKu

    (@tiku)

    That’s not really a solution. I’ll edit each release of NextGen manually instead.

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘PHP warning in package.module.nextgen_basic_singlepic.php’ is closed to new replies.