php7.3 warning

  • Resolved penhtech

    (@penhtech)


    5 years, 3 months ago

    Warning: “continue” targeting switch is equivalent to “break”. Did you mean to use “continue 2”? in /www/easylanguages_680/public/releases/20190826095602/web/app/plugins/cf7-polylang/admin/class-cf7-polylang-admin.php on line 92

    Once again, “continue 2” fixes the issue. I tried a pull request on the grid plugin but was informed I did not have permissions. I have never contributed to open source projects before (wanted to, just never had the chance) so it is probably just a setting on my GitHub account but since this is such a minor change I did not spend time to follow up. Thanks for the great plugins, by the way.

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Aurovrata Venet

    (@aurovrata)

    thanks @penhtech. Fixed in the new release

    I tried a pull request on the grid plugin but was informed I did not have permissions.

    odd, its a public repo. a PR is done by forking your own branch of the code, and then making a request (a PR) to merge it back to the main branch with your changes. As the author of the repo, I can then either accept (merge it) or reject the PR.

    I have never contributed to open source projects before (wanted to, just never had the chance)

    well better late than never ??

    Thread Starter penhtech

    (@penhtech)

    That is exactly what I did. I have never had a problem with this in the past on the private repos I have authorization on, so not sure what the issue was.

    Plugin Author Aurovrata Venet

    (@aurovrata)

    odd, let me know if you get stuck by email on vrata at syllogic dot in.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘php7.3 warning’ is closed to new replies.

Tags