Please remove .git directories from composer dependencies before uploading

  • ResolvedPlugin Contributor harmoney

    (@harmoney)


    7 years, 5 months ago

    First, thank you very much for publishing this plugin. It’s an incredibly useful tool. I’m delighted by the chance to use an official release from WP.org rather than cloning the project from GitHub.

    I noticed that three composer dependencies still have their .git directories in the WP.org zip file. Could you please revise the plugin’s GitHub to WP.org deployment process to delete those directories?

    find object-sync-for-salesforce/ -name '.git'
object-sync-for-salesforce/vendor/developerforce/force.com-toolkit-for-php/.git
object-sync-for-salesforce/vendor/pippinsplugins/wp-logging/.git
object-sync-for-salesforce/vendor/a5hleyrich/wp-background-processing/.git

    Thanks!

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Jonathan Stegall

    (@jonathanstegall)

    @harmoney thanks for the request! I tried updating the deploy script so it removes those .git folders, as well as some other things that aren’t needed to run the plugin. A dry run was successful and created the .zip file without those items, but when deploying to WordPress it breaks.

    I’d welcome any assistance you could offer on this, but at this time I don’t have a fix. Here’s the current issue in the GitHub repo: https://github.com/MinnPost/object-sync-for-salesforce/issues/96.

    Plugin Author Jonathan Stegall

    (@jonathanstegall)

    @harmoney I spoke too soon also, perhaps. I’ve released a version 1.0.4 that removes these directories. I’d like to remove further items as well (some of the vendor libraries also have test directories), but the specific git folders appear to be gone.

    Plugin Contributor harmoney

    (@harmoney)

    Excellent! Isn’t it nice when breaking issues suddenly resolve themselves?

    Thanks for cleaning up the .git directories.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Please remove .git directories from composer dependencies before uploading’ is closed to new replies.

Tags