• Hi,

    I, David Anderson, am the author of some of the code found in lib/bcloud.php in the plugin.

    This file in your plugin currently credits only Donovan Sch?nknecht for authorship; however, it also contains code that I am the author of, and which is found only in versions of the library which I released: versions which included a copyright header crediting me.

    For an example, see the method __getSignatureV4() in that file. Donovan never released any version containing any method with this name; this method was developed by my UpdraftPlus team. Your version of this method has some changes, but follows an identical procedure, with similarities that could never arise except by directly using our code to create yours:

    Mine (find this in any version from recent years of UpdraftPlus, in the file includes/S3.php), with precisely the same code comment (and see the identical code comments on preceding lines too), same spacing conventions, variable names, in the same order, clearly demonstrating the code’s origin:

    // Make Signature
    $kSecret = 'AWS4' . $this->__secretKey;
    $kDate = hash_hmac('sha256', $amzDateStamp, $kSecret, true);
    $kRegion = hash_hmac('sha256', $region, $kDate, true);
    $kService = hash_hmac('sha256', $service, $kRegion, true);
    $kSigning = hash_hmac('sha256', 'aws4_request', $kService, true);
    $signature = hash_hmac('sha256', $stringToSignStr, $kSigning);

    Your version:

    // Make Signature
    $kSecret = 'AWS4' . self::$__secretKey;
    $kDate = hash_hmac('sha256', $amzDateStamp, $kSecret, true);
    $kRegion = hash_hmac('sha256', $region, $kDate, true);
    $kService = hash_hmac('sha256', $service, $kRegion, true);
    $kSigning = hash_hmac('sha256', 'aws4_request', $kService, true);

    $signature = hash_hmac('sha256', $stringToSignStr, $kSigning);

    Open source principles both allow and encourage you to re-use code. It’s a good thing. I’m happy if more people are benefiting from my code. However, it’s also required by the licences (and by WordPress plugin directory rules) to properly credit people whose code you use; and removing copyright notices is bad practice. Possibly you forked the version in WPVivid after they removed my credit, and before they added it back (see: https://www.ads-software.com/support/topic/please-restore-copyright-attribution-for-my-open-source-code/ ).

    Thank you,
    David

  • You must be logged in to reply to this topic.