Please whitelist plugins that don’t want to be inundated with false reports

Hello,

I came here to ask the same thing. Please can you also whitelist Max Mega Menu?

The plugin reports “ERROR | ‘string’ is a reserved keyword introduced in PHP version 7.0 and cannot be invoked as a function (T_STRING)”.

The error comes from a php library, SCSSPHP, so I’d prefer not to go in and change function names as I don’t fully understand the inner workings of the library.

I believe it’s due to this: https://github.com/wimg/PHPCompatibility/issues/115

Regards,
Tom

Hi David and Tom! I’ll take a look and get this resolved. We’ve tried to make it as clear as possible that static code analysis isn’t 100% accurate, but I’ll add notes inside the plugin to try to make it more clear.

Thanks for bringing this to our attention!

I’ll add notes inside the plugin to try to make it more clear.

I was hoping for something more than more notes. We already have notes on the UpdraftPlus page saying that it’s PHP 7.0 compatible, and multiple forum threads in our forum. But, people don’t read notes… or if they do, they repeatedly ask for us to interpret the result for them, even if someone else just asked that a few threads down. We’d be much happier if there was a whitelist, or something to filter, to just be excluded from the whole thing.

Hi David,

There is a whitelist and I added both of the above plugins to it (update should be out today)! I just want to try to prevent this situation from happening by making it even more clear.

Hi Everyone,

I just created similar issue on github. (https://github.com/wpengine/phpcompat/issues/69). I’ve similar case with WPML plugins which use 3rd party library – TWIG.

Plugins which are affected: WPML Multilingual CMS – sitepress-multilingual-cms, WooCommerce Multilingual – woocommerce-multilingual.

I already saw similar cases (whitelist) on https://github.com/wpengine/phpcompat/wiki/Results

Thanks

I’ve released v1.2.2 which has UpdraftPlus and Max Mega Menu whitelisted. I’ll work on WPML in the GitHub issue.

https://cldup.com/sSJoRfE7-Q.png

Thank you!

David

@davidanderson

+1

From another plugin developer who shares your experience in this issue, I want to say thanks for your initial report, and for describing the issue so well. (FYI, we use UpdraftPlus too and recommend it to all our clients. So, thank you for your excellent work on it. Much respect.)

Over at UpdraftPlus (900,000 installs), we’re getting a regular stream of users who use this tool (or another) to test for PHP 7 compatibility, and then ask us why UpdraftPlus is not PHP7-compatible.

This is exactly what we’ve been experiencing. WP-SpamShield (100,000+ installs) and other plugins we’ve developed are getting reported as not PHP 7 compatible by this plugin. They are all 100% PHP 7 compatible, and have been for over a year as well. (We run all our plugins through rigorous compatibility testing.) The unnecessary reports & support requests have become a real headache. @octalmage : I would say that so far, this plugin is not making a lot of friends among other plugin developers.

The fact that upon the plugin’s launch – and without doing much testing – WP Engine put out press releases announcing to the world, “Web’s First WordPress PHP 7 Compatibility Checker”, only compounds this issue. :/ (Personally, I would have waited until it had proven itself in the WPorg community first before doing any kind of marketing.)

Unfortunately, though, this tool is not sufficiently intelligent.

Could not have said it better myself!

– Scott

• This reply was modified 8 years ago by redsand.
• This reply was modified 8 years ago by redsand.