Plugin activation hook is not firing on network activate which led to an js erro

I’m afraid I don’t understand. Would you please rephrase and add some more details?

Hello Steini

From the code i understand you are saving an option upon the plugin activation

function wpbu_activation() {
	add_option( 'wp_browserupdate_browsers', '0 0 0 0 0' );
	add_option( 'wp_browserupdate_js', '0 false true top true true true true' );
	add_option( 'wp_browserupdate_css_buorg', '' );
}

But this function wont run when the plugin is network activated

Related stackoverflow question : https://wordpress.stackexchange.com/questions/181141/how-to-run-an-activation-function-when-plugin-is-network-activated-on-multisite

so when this wpbu() function is called, the option doesnt exist on the db,

$browser = 'e:' . $wpbu_vars[0] . ',f:' . $wpbu_vars[1] . ',o:' . $wpbu_vars[2] . ',s:' . $wpbu_vars[3] . ( ! isset( $wpbu_vars[4] ) ? '' : ',c:' . $wpbu_vars[4] );

there are no isset checks here which led to generation of js script with syntax errors

To replicate the bug, remove the option wp_browserupdate_browsers from db and open the page.

That’s a brilliant hint. To be honest, I had no idea the networking feature would affect the way a plugin works. Will implement the changes and push an update soon. Would you be able to test and provide feedback here?

sure, i would love to.

If you point me to the plugin github repo i could even send a PR with the quick fix.

There’s no repo as of yet. Feel free to pass me the changes here or send an e-mail to wordpress at steinbrecher dot co

I have sent the fix via email ??

Received, massive thanks! Will push the update soon…