Plugin broke after 5.0.1 update

Also some console log info:

stack trace: 0 /public_html/inhoud/plugins/font-awesome/includes/class-fontawesome-svg-styles-manager.php(223): FortAwesomeFontAwesome_SVG_Styles_Manager->selfhost_asset_full_path() 1 /public_html/inhoud/plugins/font-awesome/includes/class-fontawesome.php(1042): FortAwesomeFontAwesome_SVG_Styles_Manager->is_svg_stylesheet_present() 2 /public_html/inhoud/plugins/font-awesome/includes/class-fontawesome.php(386): FortAwesomeFontAwesome->initialize_admin() 3 /public_html/inhoud/plugins/font-awesome/font-awesome-init.php(71): FortAwesomeFontAwesome->init() 4 /public_html/inhoud/plugins/font-awesome/font-awesome.php(207): require(‘…’) 5 /public_html/wp-includes/class-wp-hook.php(324): FortAwesomeFontAwesome_Loader->init_plugin() 6 /public_html/wp-includes/class-wp-hook.php(348): WP_Hook->apply_filters() 7 /public_html/wp-includes/plugin.php(517): WP_Hook->do_action() 8 /public_html/wp-settings.php(704): do_action() 9 /public_html/wp-config.php(218): require_once(‘…’) 10 /public_html/wp-load.php(50): require_once(‘…’) 11 /public_html/wp-admin/admin.php(34): require_once(‘…’) 12 /public_html/wp-admin/edit.php(10): require_once(‘…’) 13 {main}

edit.php?post_type=page:897 php version: 8.3.13
WordPress version: 6.7.2
multisite: false
is_network_admin: false

@ridle Thanks for the report.

That particular problem appears to be caused by some unexpected options data for the plugin in your WordPress database. While the error is thrown by some of the new code for the block editor support, it would be caused when the plugin can’t figure out what version of Font Awesome you’ve configured to use.

That’s a more fundamental problem that would impact other features of the plugin as well. It might occur when the state of the plugin’s options in the database gets corrupted somehow, maybe doing some kind of database migration or backup/restore that went awry.

It may resolve the problem to simply re-save the plugin’s options. If you’re in “Use CDN” mode, you could select a different version, save, and then re-select whatever version you had before, and save again. Of if you’re in “Use Kit” mode, you could “refresh kits”, pick a different kit, save, then go back and pick your original kit and re-save.

If that doesn’t work, then it may be necessary to do a deeper clean of the plugin’s state in your WordPress database. The easiest way to do that is to deactivate and uninstall the plugin (using the controls in the plugins dashboard, so the plugin’s cleanup code runs). Then re-install and re-activate.

Try one of those and let me know?

While this DOES get rid of the message, the buttons still doesn’t work sadly.

I also reinstalled the plugin from scratch.

The button is broken for me as well. I’m using the classic editor.

5.0 has the same problem, 4.5 works fine.

• This reply was modified 6 days, 23 hours ago by milesgilmour.

@ridle when you say “the buttons still doesn’t work”, are you referring to the “Add Font Awesome” button above the text input area in the Classic Editor? Or something else?

Are there any relevant-seeming messages in the browser console (aka JavaScript console) when loading that editor page? Or when clicking the button?

The Classic Editor does work as expected in my test environment, which is a clean installation of WordPress. So it seems that there’s an unexpected interaction with some other plugin that we need to figure out here.

Do you know of any other plugins that might be active on that page that might be relevant?

@milesgilmour thanks for the report. Could you provide any further information about your environment, along the lines I’ve requested in my previous comment?

@mlwilkerson

Yes I mean the button ‘Add Font Awesome’. We make use of the WYSIWYG ACF field within a ACF flexible content field.

I just confirmed 4.5.0 did work just fine, the issue started at 5.0

I don’t have any console log errors anymore.

I can confirm the problem only occurs with an Advanced Custom Fields WYSIWYG field – the button works fine in a default classic editor in a post or page, but an ACF field with the button no longer works.

@mlwilkerson

Any update on this?

@ridle I’ve investigated the interaction between ACF and this plugin. It appears that ACF is changing the button and thus removing its click event handler. It seems like it shouldn’t be doing that. But in any case, I’m working on an alternative implementation that ACF’s mechanism won’t undermine. I plan to offer a pre-release for you to test, if you’re willing, before publishing a real version in the plugins directory.

Of course, it’s possible that some other plugin will undermine either the old or new implementation. It might be impossible to make this plugin entirely resilient against what some other plugin might do. These interactions across plugins seem to be a very common problem in the WordPress ecosystem.

(I know this plugin has sometimes been at fault in the same way: accidentally causing problems for other plugins. So it goes both ways.)

@ridle and @milesgilmour I’ve posted a pre-release of the plugin here in its GitHub repo.

If you’re willing to live on the edge a little, you could try installing it to see if it resolves your problem.

You’d download the font-awesome.zip file attached that release, and install it in WordPress via “Add New Plugin” and then use “Upload Plugin” to upload that zip file.

If you try it, can you let me know how it goes?