[Plugin: BuddyPress Multilingual] Language filter bug in 1.2.1

Hi.

The ‘bpml_icl_ls_languages_filter’ removes items from the lang array if the requested slug is not part of BP’s active components and if the lang’s URL is home (lines 206 to 216 of frontend.php). The first issue is the following:
– It doesn’t deal with Sitepress’s ‘icl_lso_link_empty’ option as it should
– It “forgets” valid BP slugs like ‘register’ and ‘activate’ which are not BP active components (and maybe more)
What is this code meant to as it’s been added only since the 1.2.0 release? Shouldn’t it be simply removed as Sitepress already deals with missing translations?

Additionally, the new code for BP 1.5 (lines 218 to 238) recreates the lang array but not the same way as Sitepress:
– It leaves several attributes that Sitepress removes (‘code’, ‘english_name’, ‘display_name’ and ‘translated_url’)
– It doesn’t translate the name (‘translated_name’=’english_name’!)

Finally, the condition on line 218 is not right: it should be 1.5 instead of 1.2.9.

As a result in my opinion, this function should be deeply reviewed and fixed.

Thanks.

https://www.ads-software.com/extend/plugins/buddypress-multilingual/