• Resolved Marklcm

    (@marklcm)


    I am testing the plugin, it looks good.

    I use the Plugin Check plugin for new (to me ) plugins – it shows some errors – could you check it out please?

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author dan009

    (@dan009)

    Hi,

    Do you have a report, or link to a report?

    what plugin checker?

    regards

    Thread Starter Marklcm

    (@marklcm)

    Thanks for your quick reply.
    https://www.ads-software.com/plugins/plugin-check/

    If you install the plugin and use it to test Raffle Play it will give you the report.
    Thank you for providing and supporting Raffle Play

    Plugin Author dan009

    (@dan009)

    Hi @marklcm

    I’ve looked at the plugin and ran a test.

    The results are not accurate due to the way it processes the files in the plugin.

    I use the wordpress guidelines of building the plugins.

    $text = esc_html( '<p>This is some text</p>' );
    echo $text;

    The above code is perfectly valid and safe, but the plugin will flag it as Error because the text is not escaped but in fact is escaped.

    $url = "https://example.com?q=search";
    $url_esc = esc_url( $url);
    echo $url;

    For the above will complain the url is not escaped, but it is.

    Hope you get my point.

    The plugin uses nonce for all ajax requests.

    Doing my best to keep it at wordpress coding standards.

    Let me know if you have any other questions.

    Regards,

    Dan.

    Thread Starter Marklcm

    (@marklcm)

    The plugin (Plugin Check (PCP) is by the WordPress Performance Team and Plugin Review Team.
    I will bring it to their attention.
    It would be good if you could follow up with them as well.

    I read about the plugin before using it, they say:

    “We strive to write a plugin in a way that minimizes false positives but if you find one, please report it in the GitHub repo. For certain false positives, such as those detected by PHPCodeSniffer, you may be able to annotate the code to ignore the specific problem for a specific line.”

    It it is a tool, a very useful tool, and all tools can be improved.
    Thanks for checking and your reply.

    Plugin Author dan009

    (@dan009)

    Hi @marklcm

    I understand your point. Is very hard to code in the way the plugin checker does the checking.

    Out of curiosity, have you tried checking Woocommerce ?

    Give it a try, make sure you have enough memory on your server.

    Regards,

    Dan.

    Thread Starter Marklcm

    (@marklcm)

    Hello Dan, plugin is running well on first try. I have left a 5 star rating.

    Thanks

    • This reply was modified 7 months, 3 weeks ago by Marklcm.
Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Plugin Check errors’ is closed to new replies.