Plugin Conflict

  • Resolved codejp3

    (@codejp3)


    1 year, 8 months ago

    Hello,

    I am a co-author of the bbP Style Pack plugin, and wanted to reach out to you to work on a resolution for a plugin conflict.

    Within Style Pack, we have Moderation Tools for use with bbPress topics/replies. If your plugin is activated while trying to enable/disable those Moderation Tools in our plugin, it results in a generic “The link you followed has expired!” WP error message, and shows the following debug warning message:

    Warning: Undefined array key "miniorange_feedback_submit" in /path/to/public_html/wp-content/plugins/miniorange-otp-verification/handler/class-moactionhandlerhandler.php on line 435

    Despite getting that warning message, it doesn’t appear to have anything to do with the conflict.

    Normally after activating Moderation Tools in Style Pack, the page should reload to:

    /wp-admin/options-general.php?page=bbp-style-pack&tab=modtools

    Instead, with your plugin enabled, it kicks out that PHP warning message with a generic “link expired” WP message, with a 403 forbidden status code, at:

    /wp-admin/options.php

    No other part of Style Pack seems to have conflicts with your plugin, only Moderation Tools. The Moderation Tools themselves appear to work properly as expected. Only the settings page that allows you to activate/deactivate Moderation Tools is conflicting. What makes it strange is that that settings page follows the same structure format of all other settings pages within the Style Pack plugin, but only the Moderation Tools settings page is conflicting.

    I’ve browsed through your plugin code, but haven’t been able to find the conflict yet.

    I checked if any of our function names, form name, nonce name, field names, (and so on) exist within your plugin and they don’t as far as I can tell, so that shouldn’t be the conflict.

    You use namespacing and all of our relevant classes start with “bspbbPressModTools” (and those Moderation Tools are actually functioning properly) so there’s shouldn’t be any class name conflicts.

    I’ve tried to identify the conflict on our side without any success, so I’m asking you to do the same on your end.

    Until we get this resolved, I’m instructing our plugin users who experience this issue to temporarily deactivate your plugin, enable (or disable) Moderation Tools in our plugin, and then re-activate your plugin.

    You can see this support topic for additional details. Thank you for time and cooperation with this conflict between our plugins.

Viewing 4 replies - 1 through 4 (of 4 total)
  • Thread Starter codejp3

    (@codejp3)

    Quick Update.

    I still haven’t determined the actual cause yet, but I have narrowed it down to your plugin feedback functionality.

    Simply renaming /views/feedback.php to /views/feedback.disabled fixes the conflict.

    Doing that, both plugins seem to work as expected (except for your plugin feedback on deactivation functionality).

    Hope that helps point you in the right direction for patching this conflict!

    Thread Starter codejp3

    (@codejp3)

    Update and Workaround

    I’ve been able to successfully prevent the conflict with Style Pack by adding this code snippet:

    // force a fix for miniOrange plugins that conflict with Moderation Tools
function remove_minorange_feedback() {
        $mo_otp = \OTP\MoInit::instance();
        remove_action( 'admin_footer', array( $mo_otp, 'feedback_request' ) );
}
add_action('init', 'remove_minorange_feedback');

    I’m not going to release this as part of our plugin yet. I’m going to give you a chance to change the code within miniOrange plugins before we forcefully deactivate your feedback functionality.

    My recommended change is within \OTP\MoInit\initialize_hooks to wrap the “add_action admin_footer” for “feedback_request” so that it only does so on the /wp-admin/plugins.php page instead of EVERYWHERE in the admin panel. That way it will still work as you want, and won’t conflict with our plugin any more.

    My guess is that you use the same plugin feedback functionality within all of your plugins, so the recommended change would apply to all of them. Like I said, I’ll give you a chance to patch them all.

    Hello @codejp3,

    Thanks for contacting us.

    We have checked the above pointed issue and figured out that it is because of the unclosed “form” tag in the file wp-content\plugins\bbp-style-pack\includes\settings_moderation.php on line number 12 of the bbP Style Pack plugin.

    You can refer the screenshot: Code Screenshot.

    We have tested the functionality by closing the form tag mentioned above and it is working fine.

    • This reply was modified 1 year, 8 months ago by ganeshpawar.
    Thread Starter codejp3

    (@codejp3)

    @ganeshpawar – thank you for your input.

    I have verified that it is indeed because of a missing </form> tag. We will issue an update for this shortly. Sometimes the simplest things will break a plugin. Glad you were able to spot this, because clearly I missed it.

    Resolved

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Plugin Conflict’ is closed to new replies.