Plugin conflict due to bad global function name

  • Resolved SiteBolts

    (@sitebolts)


    1 year, 6 months ago

    Hi there, this plugin is conflicting with another plugin that we use (Product Video Gallery for Woocommerce) due to a global function name conflict in the JavaScript.

    Both plugins create a function called getParameterByName , but with a different parameter order. This breaks the product video galleries because your plugin takes priority and overwrites their function.

    I’ve reported it to that plugin’s developer as well, but this is ideally something that should be fixed in both plugins. Global functions, especially ones with common names like getParameterByName, need to be either turned into class functions so that they don’t clash with other scripts or be given a prefix so that they look something like hafeGetParameterByName.

    In your case, the function is defined in admin/js/admin.min.js

Viewing 1 replies (of 1 total)
  • Plugin Support Md. Anower Hossain

    (@anowerhossain16)

    Hi @sitebolts,

    Thank you for bringing this to our attention. We apologize for any inconvenience caused by the conflict between our plugin, HappyAddons, and the “Product Video Gallery for WooCommerce” plugin. However, please note that our plugin has no integration with the “Product Video Gallery for WooCommerce” plugin.

    Regarding the global function name conflict, we appreciate your suggestion to turn the function into a class function or give it a prefix to avoid clashes with other scripts. We will take your suggestion into consideration and try to implement a solution in future updates of our plugin. In the meantime, we suggest reaching out to the developer of the “Product Video Gallery for WooCommerce” plugin to see if they can update their plugin to avoid conflicts with other plugins.

    Thank you for your understanding and please let us know if there is anything else we can do to assist you.

    Have a nice day.

Viewing 1 replies (of 1 total)
  • The topic ‘Plugin conflict due to bad global function name’ is closed to new replies.