[Plugin: Google XML Sitemaps] Early testers wanted

@arnee: I have created another sitemap for sub-blog account (WP3 Multisite) and google webmaster tools downloaded it successfuly (https://tzmatulji.hr/iznajmljivaci/sitemap.xml).

But there is still no luck with main site sitemap, although I don’t see any obvious problem.

Is this going to support custom post types?

@ip00: Thank you very much for testing. I’ve changed some small things and the content-type of the XML sitemap to application/xml, can you try on the non-working blog again? Please make sure to resubmit your sitemap in the Webmaster Tools manually.

https://downloads.www.ads-software.com/plugin/google-sitemap-generator.4.0a3.zip

@jgadbois: I will focus on the core changes first, but this feature will come sooner or later.

@arnee
I added this to htaccess

RewriteRule ^sitemap.xml$ /index.php?xml_sitemap=index [R=301,L]
RewriteRule ^sitemap-posts-([0-9]+)-([0-9]+).xml$ /index.php?xml_sitemap=params=posts-$1-$2 [R=301,L]

No arnee it didn’t work. I deleted older version of your plugin from server, uploaded new one and activated it, added new post to generate new sitemap and submitted it manually go WMT.
Is there anything else I should do? Plugin kept settings from old version even after it was deleted and reinstalled.

@mmilan81: This rules should be automatically added to the WordPress redirect functions on plugin activation. Did you activate the plugin or just replaced the old files with the new version? In this case you could try to click the Save button on the WordPress permalink options page. There are more rules for sub-sitemaps than the two you’ve added manually, so changing the .htaccess by hand is a lot of work…

ip00: Hmmm thats strange, Google still says it is HTML? The headers are sent correctly, I really have no idea whats wrong. Yes, the settings are kept from each version, so you won’t lose them on an upgrade. There is a reset button at the end of the page, but I don’t think that will change the content-type issue. ??

@arnee
I deactivated and deleted old version, than activated new. I tried to deatcivate & activate plugin few times, also changed link structure to default and back and problem was same.

Temporarily solution was those two lines. I’ll try ver 4.0a3 later.

Regarding my problem it was not related to this plugin, but WP redirect settings.

Thanks, arnee

Got it going on a couple of sites. Google is reading most of the sub-sitemap links from the main sitemap page but I’m getting a blank page with others. When I view the source i get this

<?xml version="1.0" encoding="UTF-8"?><?xml-stylesheet type="text/xsl" href="https://www.myefficientenergy.com/wp-content/plugins/google-sitemap-generator/sitemap.xsl"?><!-- generator="wordpress/2.9.2" -->
<!-- sitemap-generator-url="https://www.arnebrachhold.de" sitemap-generator-version="4.0alpha3" -->
<!-- generated-on="August 23, 2010 7:01 pm" -->
<urlset xmlns:xsi="https://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="https://www.sitemaps.org/schemas/sitemap/0.9 https://www.sitemaps.org/schemas/sitemap/0.9/sitemap.xsd" xmlns="https://www.sitemaps.org/schemas/sitemap/0.9"><br />
<b>Fatal error</b>:  Allowed memory size of 67108864 bytes exhausted (tried to allocate 128 bytes) in <b>/mysite.com/wp-settings.php</b> on line <b>307</b><br />

Also in firefox I get this error.

XML Parsing Error: no element found
Location: https://myblog.com/sitemap-posts-2010-01.xml
Line Number 4, Column 236:<urlset xmlns:xsi="https://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="https://www.sitemaps.org/schemas/sitemap/0.9 https://www.sitemaps.org/schemas/sitemap/0.9/sitemap.xsd" xmlns="https://www.sitemaps.org/schemas/sitemap/0.9">
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------^

Please try the new version, hopefully this is fixed now ??

https://downloads.www.ads-software.com/plugin/google-sitemap-generator.4.0a4.zip

Arnee: Custom post types didn’t work for me, but I found the problem. Line 826 of sitemap-ui.php (the a4 build) says:
if(count($taxonomies)>0) {
And it should be:
if(count($custom_post_types)>0) {

Also, is there a reason that you limit support for custom taxonomies to be only taxonomies applied to posts? It seems like GetCustomTaxonomies() in sitemap-core.php should be:

function GetCustomTaxonomies() {
	$taxonomies = get_taxonomies();
	return array_diff($taxonomies,array("category","post_tag","nav_menu","link_category"));
}

I appreciate the plugin. Thanks for all the hard work. Here are some more fixes I had to make. First, just to make the custom post type sitemap url work (https://shouldipourit.com/sitemap-beers-2010-08.xml) I had to edit sitemap-builder.php. In the switch statment in the Content() funtion I moved the posts and pages cases to the bottom and made that the default:

case "posts":
case "pages":
default:
	$this->BuildPosts($gsg, $type, $params);

To make the index work (https://shouldipourit.com/sitemap.xml) I first added the processing for custom post types after the processing for posts and pages, but the code was basically all duplicate, so I remove the whole if (in_posts || in_pages) part of the Index() function in sitemap-builder.php and replaced it with this:

$posttypes = $gsg->GetOption('in_customtypes');
if ( !is_array($posttypes) ) {
	$posttypes = array();
}
if($gsg->GetOption("in_pages")){
	array_unshift($posttypes, 'page');
}
if($gsg->GetOption("in_posts")){
	array_unshift($posttypes, 'post');
}

//Add filter to remove password protected posts
add_filter('posts_search',array($this,'FilterPassword'),10,2);

//Add filter to remove fields
add_filter('posts_fields',array($this,'FilterIndexFields'),10,2);

//Add filter to group
add_filter('posts_groupby',array($this,'FilterIndexGroup'),10,2);

foreach($posttypes as $posttype) {
	$qp = $this->BuildPostQuery($gsg,$posttype);

	$qp['cache_results']=false;

	$posts = @get_posts($qp);
	if ($posts) {
		foreach ($posts as $arcresult) {
			$gsg->AddSitemap($posttype.'s',sprintf("%04d-%02d",$arcresult->year,$arcresult->month), $gsg->GetTimestampFromMySql($arcresult->last_mod));
		}
	}
}
//Remove the filters again
remove_filter('posts_where',array($this,'FilterPassword'),10,2);
remove_filter('posts_fields',array($this,'FilterIndexFields'),10,2);
remove_filter('posts_groupby',array($this,'FilterIndexGroup'),10,2);

Everything seems to work as expected now.

moved to 4.0a4 and got this error in the sitemap

Fatal error: Cannot use object of type GoogleSitemapGenerator as array in /home/myblog.com/wp-includes/plugin.php on line 680

Hi Arne – I’ve put this on a test site, and you can see the sitemaps here:
https://www.investingguide.com.au/sitemap.xml
https://www.investingguide.com.au/directory/sitemap.xml

They look to be working correctly. I have a couple of questions though:
1 – Do you know if there is any issue with Google if my site has two sitemaps? If so, have I set something up wrong? Or should I manually add the /directory home page url in the ‘additional pages’ section of the main site’s sitemap settings?
2 – I noticed that it no longer lists all links on one page, but links to sub-pages with the sitemap (eg. https://www.investingguide.com.au/sitemap-pages-2010-08.xml). Is that correct or have I also set this up wrong?

Thank you so much for this plugin. I hope we’re not causing you too many headaches!?!?

Cheers, Rob