Plugin integration View Admin As

  • Resolved Jory Hogeveen

    (@keraweb)


    7 years, 2 months ago

    Hello, I’d like to integraty my plugin View Admin As with this one.
    Currently all my admin bar nodes are displayed on the customze UI but there are two problems with that:

    – The order and location of admin bar sub-nodes are important to stay intact, users shouldn’t change those. Is there a way to remove them from your page?
    Changing the main plugin node location won’t be a problem.

    – I use form elements within admin menu nodes. This cause an error with your plugin (the page doesn’t save). This is another reason to remove my sub-nodes from the admin bar edit screen.

    View Admin As only works within the admin bar.

    Please check it out and you’ll see what I mean. I’d like to work on a form of intergration with you. I currently can’t find any filter hooks which I can use to change the possible admin bar settings.

    Thanks! Jory

    The page I need help with: [log in to see the link]

Viewing 14 replies - 1 through 14 (of 14 total)
  • Plugin Author gqevu6bsiz

    (@gqevu6bsiz)

    Hello Jory,

    Thank you for your inquiry.
    Maybe, I understand to your problem details. In other words of View Admin As: All sub-nodes to dynamically.
    And I fix it.
    Could you please check the work with View Admin As?
    WP Admin UI Customize 1.5.11-beta

    You can change the main plugin node location.

    [ Signature moderated ]

    • This reply was modified 7 years, 2 months ago by Jan Dembowski.
    Thread Starter Jory Hogeveen

    (@keraweb)

    Hi @gqevu6bsiz,

    I’ve tested 1.5.11-beta and it looks good for the most part!

    I’ve added some filters in there to other plugins could intergrate themselves (prevents you from doing all the work!).
    Do you have a GitHub repo or something so I can send you the update?

    There is only one thing that isn’t working yet. In the View Admin As settings you have the option to move the main node under “My Account”, so the main node would be a sub-menu node then.
    Any ideas if that could integrate with your plugin? Otherwise I could disable this feature if wauc is active.

    Let me know and thanks,
    Jory

    Plugin Author gqevu6bsiz

    (@gqevu6bsiz)

    Hi Jory,

    Thank you for your working check and I have relieved it looks like working well. ??
    I saw to a problem of your pointed out(Change the location menu node option).

    Thank you added some filters and I created a repository but sorry I’m not a good GitHub how-to-use.
    https://github.com/gqevu6bsiz/WP-Admin-UI-Customize-test
    Can you add/intergration to GitHub repo?

    And for a problem to change the location node, I think it would be better to disable it if wauc, because plugin users is self select the location on wauc.
    OR, add nodes of View Admin As after WP Admin UI Customize.

    [ Signature moderated ]

    • This reply was modified 7 years, 2 months ago by Jan Dembowski.
    Thread Starter Jory Hogeveen

    (@keraweb)

    Hello @gqevu6bsiz,

    Perfect! I’ve added a pull request on GitHub: https://github.com/gqevu6bsiz/WP-Admin-UI-Customize-test/pull/1
    I also added some other filters in there for possible use for other plugins.
    Let me know what you think!

    And for a problem to change the location node, I think it would be better to disable it if wauc, because plugin users is self select the location on wauc.
    OR, add nodes of View Admin As after WP Admin UI Customize.

    True, but I don’t think wauc allows changing the order/location of submenu nodes right? This option does and I know some users like to have this module in the “My Account” submenu.
    I will think about how to best implement this.

    About the View Admin As intergration. Would you like to keep it in your plugin or shall I add it in mine with use of the new filters?

    Thanks, Jory

    Thread Starter Jory Hogeveen

    (@keraweb)

    Hello @gqevu6bsiz,

    I found another issue. Since WAUC only allows a depth of 4 levels it removes some of the VAA nodes. In some cases VAA can have a depth of 5 or more.

    I removed all VAA compatibility code from your plugin, added some extra filters, and wrote the compatibility in View Admin As.

    Pull Request for your plugin:
    https://github.com/gqevu6bsiz/WP-Admin-UI-Customize-test/pull/1

    Compatibility code in View Admin As:
    https://github.com/JoryHogeveen/view-admin-as/pull/75/commits/d6d70ff4c856c2d878cb928a2be8057d0a99f5f3

    • If the user has selected “My Account” for the VAA location. WAUC cannot modify it’s location.
    • If the user has selected the default location for VAA it can be moved with WAUC.
    • All the menu nodes from VAA will be added, even depth 5 or more.

    Let me know what you think!

    Thanks, Jory

    • This reply was modified 7 years, 2 months ago by Jory Hogeveen.
    Plugin Author gqevu6bsiz

    (@gqevu6bsiz)

    Hi Jory,
    Thank you for your details.

    If the user has selected “My Account” for the VAA location. WAUC cannot modify it’s location.
    If the user has selected the default location for VAA it can be moved with WAUC.

    I think also your ideas is better, Thankyou!:)

    And thank you for your pull requests.
    I’m considering another compatibility of your requests.

    [ Signature moderated ]

    • This reply was modified 7 years, 2 months ago by Jan Dembowski.
    Thread Starter Jory Hogeveen

    (@keraweb)

    Hi @gqevu6bsiz,

    Ok perfect!
    If you need any help with GitHub let me know!
    Also, let me know when you would like to release 1.5.11 so I can schedule my update as well :).

    Thanks, Jory

    Moderator Jan Dembowski

    (@jdembowski)

    Forum Moderator and Brute Squad

    Side note to @gqevu6bsiz I do not want to have a conversation about this but lose the signature.

    That’s actually prohibited here.

    https://www.ads-software.com/support/guidelines/#avoid-signatures

    Plugin Author gqevu6bsiz

    (@gqevu6bsiz)

    Hello Jan,
    Thank you for your point out and sorry.
    I will be careful, Thanks.

    Plugin Author gqevu6bsiz

    (@gqevu6bsiz)

    Hi Jory,

    I’m sorry for my late reply and thank you for your pull requests.
    I checked to your pull requests and marge, and nothing problems.:)
    I think View Admin As admin bar is all filter/action working with WP Admin UI Customize.
    I will update to 1.5.11 after a little other problem fix.
    Maybe, I will probably update on next week.
    Please tell me if you have/get some problems for this update. Thanks.

    Thread Starter Jory Hogeveen

    (@keraweb)

    Hi @gqevu6bsiz,

    No problemo, for me the integration using the filters works perfectly!
    I’ll mark this topic as resolved.

    Plugin Author gqevu6bsiz

    (@gqevu6bsiz)

    Hi Jory,
    Thank you for your resolved and integration working check!:)

    Thread Starter Jory Hogeveen

    (@keraweb)

    Added another filter: https://github.com/gqevu6bsiz/WP-Admin-UI-Customize-test/pull/2
    Sorry that I just came up with that one after the release. Please consider it for the next release :).

    Plugin Author gqevu6bsiz

    (@gqevu6bsiz)

    Thank you for your pull request and I can see to your add filter.
    I just released to 1.5.11 and sorry, next release is I will be a little later.
    And I will include your pull request in next release :).

Viewing 14 replies - 1 through 14 (of 14 total)
  • The topic ‘Plugin integration View Admin As’ is closed to new replies.