[Plugin: Keyring] Contribution

Hi Ryan, thanks for volunteering! I need to do a pretty big merge back into the plugin version of Keyring from changes that I have running on a production instance already. The main thing that would change is to handle request tokens in a similar fashion to access tokens, but there’s a lot of differences unfortunately, which is why I keep putting it off ??

Once that’s done, you’d be more than welcome to submit any patches for fixes etc, and/or we can discuss suggestions and features to see how we can flesh things out.

Beau, Sounds good, if there is anything I can do to help, let me know, I am going to start working on integrating this into our codebase which will be in production as soon as we have it working, so, if I can aid in thee merge to help move it along, I will, I don’t want to have to re-write something similar. So, if you have an idea of a timeline, it would help me figure out some of our upcoming feature releases.

Thanks,
Ryan

Hi Ryan,

So you may have seen that there was a pretty big update recently. I’ve got a few more things coming in the near future, but hopefully not too much more that’s breaking or will significantly change work-flow etc.

Check it out and let me know what you think — the biggest changes were around the introduction of the concept of core-handled request tokens, and how the Token Store class works.

Cheers,
Beau

So, can we say now that it’s probably safe to use it as a base for other plugins?

(Oh, and where is wp.com in list of supported services? :))

Probably not quite yet, although it’s a lot closer to “stable” now than it was. There are definitely some more changes with error handling coming up, and probably some other lower-level bits, but if you’re wanting to get in and try it out on something experimental then it should be pretty good now.

It’s quite likely that breaking changes will still happen though, so keep that in mind before updating to any future versions. I’ll try to mark that clearly in the Changelog.

Good question RE: WP.com. I haven’t needed it yet, and we don’t use it internally (since we can just access things directly), but I should be able to add a basic Service definition pretty easily.