[Plugin: MudSlideShow] Malformed generated code problem
-
Hi!
I set up to try your plugin but found a problem with the code generated for galleries in a page. For instance:
[mudslide:flickr,0,89687103@N00,72157615386874737]
I pinpointed the problem to a quote escaping problem on mudslideshow.php function muds_gallery. When assigning the variable
$updatelink
bogus<br />
were being inserted in the javascript for theonclick
attribute of the generateda
tag.The obvious solution was to convert said javascript into a one-liner and replace quotes with the corresponding entity
"
. The result is somewhat less legible, but it works on my server:$updatelink = "<div id='throbber-msspage$rand' class='throbber-off'><a style='cursor : pointer;' id='mss-update-$rand' onclick='var aux = document.getElementById("throbber-msspage$rand");aux.setAttribute("class", "throbber-on");aux.setAttribute("className", "throbber-on");muds_update( "gallery", {$aux['id']},"{$aux['type']}", "{$aux['user']}", "{$aux['gallery']}", $first, $last, $conf, $rand );'>".__('Update','mudslide')."</a></div>";
I have noticed other problems (i.e.: including descriptions in galleries seem to break them, skipping random images), but with this tiny fix I can use your plugin. Thank you for your effort!
- The topic ‘[Plugin: MudSlideShow] Malformed generated code problem’ is closed to new replies.