[Plugin: New User Approve] Mistakes in the plugin

  • Resolved Marko Heijnen

    (@markoheijnen)


    12 years, 6 months ago

    I was looking in the code since there was a false reference to the function screen_layout_columns() that doesn’t exists in the current release. As it does in the branche “1.4”.

    Branche “1.4” Should have been trunk since that is the most recent code.

    Also switching to a role check if someone is unapproved is wrong. This makes it harder for the user to approve someone because he/she need to think and select which role a user has. The old way was better. To make a solution for it, it is better to store the selected role in a user meta field and create a approve button in the user overview so the user can approve someone without the need to edit someones profile/role.

    Another note is that the upgrade_plugin() method shouldn’t be hooked to init. The best is on plugin activation otherwise admin_init. Also role will not be made for existed plugins since options is set. Also the version number is wrong and should probably be a class variable.

    https://www.ads-software.com/extend/plugins/new-user-approve/

Viewing 2 replies - 1 through 2 (of 2 total)
  • Thread Starter Marko Heijnen

    (@markoheijnen)

    Btw at this moment the legacy interface needs a lot more code since when you switch back to legacy interface you remove the role and everything will break. User get no role and doesn’t show up in the approved/denied users screen

    The 1.4 branch is being experimented with. That version has not been completed or tested. I’d recommend using the stable version, which is currently 1.3.3.

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘[Plugin: New User Approve] Mistakes in the plugin’ is closed to new replies.