[Plugin: Portfolio Slideshow] Height of image container is wrong

OK I’ve had a look through the code and I’ve found this line
$(this).parent().css("height", $oht + $pht + $ht + $qht - 30);';

When I got rid of the “-30” it seems to work fine now.

So why is this “-30” there I wonder?

Thanks for the plugin though it suits a lot of my projects brilliantly.

B

Hey there,
Yes, you’re not the first one to notice this problem. The calculations for the various possible bits of content (title, description, caption) in the slideshow are not exact and I discovered a lot of extra space was making it’s way in there. Sometimes 50px extra or more, depending on the theme! So I added that -30 as a kludge to make the container height reasonable for most themes… and I think it actually works most of the time.

The problem is sometimes people don’t use captions or titles or don’t have much padding in their CSS and the -30 then hides the nav. So I need to think about this problem a little more… probably better to have the extra space, which can be fixed with a little CSS, than for people to have problems with the hidden nav.

Or maybe I need to put an additional option in there for people to set the spacing themselves if they get into a problem?

I’ll keep thinking about it. Definitely room for improvement.
Cheers,
Dalton